From edb4d7b84efa726c2e8e1c7d6e5c934182c29668 Mon Sep 17 00:00:00 2001 From: Mathias Jakobsen Date: Fri, 27 Oct 2023 11:00:46 +0100 Subject: [PATCH] Merge pull request #15455 from overleaf/mj-enable-all-the-things [web] Enable skipped cypress tests GitOrigin-RevId: 36cffbb2cc72ffb4cae9e5b8eaa57f7ba7929fa7 --- .../components/pdf-preview/pdf-synctex-controls.spec.tsx | 6 ++---- .../features/history/components/change-list.spec.tsx | 3 +-- .../test/frontend/shared/hooks/use-detach-layout.spec.tsx | 6 ++---- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/services/web/test/frontend/components/pdf-preview/pdf-synctex-controls.spec.tsx b/services/web/test/frontend/components/pdf-preview/pdf-synctex-controls.spec.tsx index b520a9af56..f8bc2263fa 100644 --- a/services/web/test/frontend/components/pdf-preview/pdf-synctex-controls.spec.tsx +++ b/services/web/test/frontend/components/pdf-preview/pdf-synctex-controls.spec.tsx @@ -83,8 +83,7 @@ describe('', function () { cy.interceptEvents() }) - // eslint-disable-next-line mocha/no-skipped-tests - it.skip('handles clicks on sync buttons', function () { + it('handles clicks on sync buttons', function () { cy.interceptCompile() const scope = mockScope() @@ -214,8 +213,7 @@ describe('', function () { cy.get('.synctex-control-icon').should('not.exist') }) - // eslint-disable-next-line mocha/no-skipped-tests - it.skip('send set highlights action', function () { + it('send set highlights action', function () { cy.interceptCompile() const scope = mockScope() diff --git a/services/web/test/frontend/features/history/components/change-list.spec.tsx b/services/web/test/frontend/features/history/components/change-list.spec.tsx index 6a387d4463..80874ada1a 100644 --- a/services/web/test/frontend/features/history/components/change-list.spec.tsx +++ b/services/web/test/frontend/features/history/components/change-list.spec.tsx @@ -435,8 +435,7 @@ describe('change list', function () { waitForData() }) - // eslint-disable-next-line mocha/no-skipped-tests - it.skip('adds badge/label', function () { + it('adds badge/label', function () { cy.findAllByTestId('history-version-details').eq(1).as('version') cy.get('@version').within(() => { cy.findByRole('button', { name: /more actions/i }).click() diff --git a/services/web/test/frontend/shared/hooks/use-detach-layout.spec.tsx b/services/web/test/frontend/shared/hooks/use-detach-layout.spec.tsx index 113dde762a..3d9b0085a2 100644 --- a/services/web/test/frontend/shared/hooks/use-detach-layout.spec.tsx +++ b/services/web/test/frontend/shared/hooks/use-detach-layout.spec.tsx @@ -66,8 +66,7 @@ describe('useDetachLayout', function () { cy.get('#role').should('have.text', 'detacher') }) - // eslint-disable-next-line mocha/no-skipped-tests - it.skip('detacher role', function () { + it('detacher role', function () { // 1. create hook in detacher mode window.metaAttributesCache.set('ol-detachRole', 'detacher') @@ -136,8 +135,7 @@ describe('useDetachLayout', function () { }) }) - // eslint-disable-next-line mocha/no-skipped-tests - it.skip('reset detacher role when other detacher tab connects', function () { + it('reset detacher role when other detacher tab connects', function () { // 1. create hook in detacher mode window.metaAttributesCache.set('ol-detachRole', 'detacher')