github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Move webpack:production out of install_deps (#20542)

Browse source 
GitOrigin-RevId: 43d0352e5ecccf057c2de47602a63f82d277d284
This commit is contained in:
Alf Eaton 2024-09-27 11:31:10 +01:00 committed by Copybot
parent e41e11bc23
commit ed343e7a16
2 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/web/Dockerfile
View file

@ -4,9 +4,6 @@ FROM node:18.20.2 AS base
WORKDIR /overleaf/services/web WORKDIR /overleaf/services/web
# install_deps changes app files and installs npm packages
# as such it has to run at a later stage
# Google Cloud Storage needs a writable $HOME/.config for resumable uploads # Google Cloud Storage needs a writable $HOME/.config for resumable uploads
# (see https://googleapis.dev/nodejs/storage/latest/File.html#createWriteStream) # (see https://googleapis.dev/nodejs/storage/latest/File.html#createWriteStream)
RUN mkdir /home/node/.config && chown node:node /home/node/.config RUN mkdir /home/node/.config && chown node:node /home/node/.config
@ -55,7 +52,7 @@ USER node
# the webpack image has deps+src+webpack artifacts # the webpack image has deps+src+webpack artifacts
FROM dev AS webpack FROM dev AS webpack
USER root USER root
RUN chmod 0755 ./install_deps.sh && ./install_deps.sh RUN OVERLEAF_CONFIG=/overleaf/services/web/config/settings.webpack.js npm run webpack:production
# intermediate image for removing source maps ahead of copying into final production image # intermediate image for removing source maps ahead of copying into final production image

5
services/web/install_deps.sh
View file

@ -1,5 +0,0 @@
#!/bin/bash
OVERLEAF_CONFIG=/overleaf/services/web/config/settings.webpack.js npm run webpack:production & WEBPACK=$!
wait $WEBPACK && echo "Webpack complete" || exit 1