github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-02-17 09:53:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

More thorough tests for the FileStoreController when downloading .html files.

Browse source
This commit is contained in:
Shane Kilkelly 2015-08-20 15:56:56 +01:00
parent aab7a8713e
commit ebf754904f
1 changed files with 54 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

87
services/web/test/UnitTests/coffee/FileStore/FileStoreControllerTests.coffee
View file

@ -66,44 +66,65 @@ describe "FileStoreController", ->
done()
@controller.getFile @req, @res
describe "with an HTML file", ->
beforeEach ->
@user_agent = 'A generic browser'
@file.name = 'really_bad.html'
@req.get = (key) =>
if key == 'User-Agent'
@user_agent
describe "from firefox", ->
# Test behaviour around handling html files
['.html', '.htm', '.xhtml'].forEach (extension) ->
describe "with a '#{extension}' file extension", ->
beforeEach ->
@user_agent = "A Firefox browser"
@user_agent = 'A generic browser'
@file.name = "bad#{extension}"
@req.get = (key) =>
if key == 'User-Agent'
@user_agent
it "should not set Content-Type", (done) ->
@stream.pipe = (des) =>
@res.setHeader.calledWith("Content-Type", "text/plain").should.equal false
done()
@controller.getFile @req, @res
describe "from a non-ios browser", ->
describe "from an iPhone", ->
it "should not set Content-Type", (done) ->
@stream.pipe = (des) =>
@res.setHeader.calledWith("Content-Type", "text/plain").should.equal false
done()
@controller.getFile @req, @res
describe "from an iPhone", ->
beforeEach ->
@user_agent = "An iPhone browser"
it "should set Content-Type to 'text/plain'", (done) ->
@stream.pipe = (des) =>
@res.setHeader.calledWith("Content-Type", "text/plain").should.equal true
done()
@controller.getFile @req, @res
describe "from an iPad", ->
beforeEach ->
@user_agent = "An iPad browser"
it "should set Content-Type to 'text/plain'", (done) ->
@stream.pipe = (des) =>
@res.setHeader.calledWith("Content-Type", "text/plain").should.equal true
done()
@controller.getFile @req, @res
# None of these should trigger the iOS/html logic
['x.html-is-rad', 'html.pdf', 'bare'].forEach (filename) ->
describe "with filename as '#{filename}'", ->
beforeEach ->
@user_agent = "An iPhone browser"
@user_agent = 'A generic browser'
@file.name = filename
@req.get = (key) =>
if key == 'User-Agent'
@user_agent
it "should set Content-Type to 'text/plain'", (done) ->
@stream.pipe = (des) =>
@res.setHeader.calledWith("Content-Type", "text/plain").should.equal true
done()
@controller.getFile @req, @res
['iPhone', 'iPad', 'Firefox', 'Chrome'].forEach (browser) ->
describe "downloaded from #{browser}", ->
beforeEach ->
@user_agent = "Some #{browser} thing"
describe "from an iPad", ->
beforeEach ->
@user_agent = "An iPad browser"
it "should set Content-Type to 'text/plain'", (done) ->
@stream.pipe = (des) =>
@res.setHeader.calledWith("Content-Type", "text/plain").should.equal true
done()
@controller.getFile @req, @res
it 'Should not set the Content-type', (done) ->
@stream.pipe = (des) =>
@res.setHeader.calledWith("Content-Type", "text/plain").should.equal false
done()
@controller.getFile @req, @res