github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-29 13:53:40 -05:00
Code Issues Projects Releases Packages Wiki Activity

fix performance of update removal

Browse source
This commit is contained in:
Brian Gough 2019-10-09 11:11:15 +01:00
parent 616c673ead
commit ebbe728ec1
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/track-changes/app/coffee/RedisManager.coffee
View file

@ -21,7 +21,7 @@ module.exports = RedisManager =
multi = rclient.multi()
# Delete all the updates which have been applied (exact match)
for update in docUpdates or []
multi.lrem Keys.uncompressedHistoryOps({doc_id}), 0, update
multi.lrem Keys.uncompressedHistoryOps({doc_id}), 1, update
multi.exec (error, results) ->
return callback(error) if error?
# It's ok to delete the doc_id from the set here. Even though the list

4
services/track-changes/test/unit/coffee/RedisManager/RedisManagerTests.coffee
View file

@ -56,12 +56,12 @@ describe "RedisManager", ->
it "should delete the first update from redis", ->
@rclient.lrem
.calledWith("UncompressedHistoryOps:#{@doc_id}", 0, @jsonUpdates[0])
.calledWith("UncompressedHistoryOps:#{@doc_id}", 1, @jsonUpdates[0])
.should.equal true
it "should delete the second update from redis", ->
@rclient.lrem
.calledWith("UncompressedHistoryOps:#{@doc_id}", 0, @jsonUpdates[1])
.calledWith("UncompressedHistoryOps:#{@doc_id}", 1, @jsonUpdates[1])
.should.equal true
it "should delete the doc from the set of docs with history ops", ->