github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-03-03 18:12:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #70 from overleaf/bg-metric-for-invalid-hash

Browse source 
add metric for invalid hash and other sharejs errors
This commit is contained in:
Brian Gough 2019-06-12 13:50:34 +01:00 committed by GitHub
commit e8dd1aae9c
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
services/document-updater/app/coffee/ShareJsUpdateManager.coffee
View file

@ -48,6 +48,7 @@ module.exports = ShareJsUpdateManager =
error = new Errors.DeleteMismatchError("Delete component does not match")
return callback(error)
else
metrics.inc "sharejs.other-error"
return callback(error)
logger.log project_id: project_id, doc_id: doc_id, error: error, "applied update"
model.getSnapshot doc_key, (error, data) =>
@ -55,7 +56,11 @@ module.exports = ShareJsUpdateManager =
# only check hash when present and no other updates have been applied
if update.hash? and incomingUpdateVersion == version
ourHash = ShareJsUpdateManager._computeHash(data.snapshot)
return callback(new Error("Invalid hash")) if ourHash != update.hash
if ourHash != update.hash
metrics.inc "sharejs.hash-fail"
return callback(new Error("Invalid hash"))
else
metrics.inc "sharejs.hash-pass", 0.001
docLines = data.snapshot.split(/\r\n|\n|\r/)
callback(null, docLines, data.v, model.db.appliedOps[doc_key] or [])