From 4070b0ef6f0ad787644b1d9ce22373c89b47e4ba Mon Sep 17 00:00:00 2001 From: Jakob Ackermann Date: Thu, 16 May 2019 14:58:32 +0200 Subject: [PATCH] [misc] tests: fix a static test `ProjectHistoryRedisManager.queueOps` is masked and can not push changes into redis during the unittest. Signed-off-by: Jakob Ackermann --- .../test/unit/coffee/RedisManager/RedisManagerTests.coffee | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/services/document-updater/test/unit/coffee/RedisManager/RedisManagerTests.coffee b/services/document-updater/test/unit/coffee/RedisManager/RedisManagerTests.coffee index 99035a32b3..b666163762 100644 --- a/services/document-updater/test/unit/coffee/RedisManager/RedisManagerTests.coffee +++ b/services/document-updater/test/unit/coffee/RedisManager/RedisManagerTests.coffee @@ -445,13 +445,12 @@ describe "RedisManager", -> describe "with project history disabled", -> beforeEach -> - @rclient.rpush = sinon.stub() @settings.apis.project_history.enabled = false @RedisManager.getDocVersion.withArgs(@doc_id).yields(null, @version - @ops.length) @RedisManager.updateDocument @project_id, @doc_id, @lines, @version, @ops, @ranges, @updateMeta, @callback it "should not push the updates into the project history ops list", -> - @rclient.rpush.called.should.equal false + @ProjectHistoryRedisManager.queueOps.called.should.equal false it "should call the callback", -> @callback @@ -493,7 +492,6 @@ describe "RedisManager", -> describe "with no updates", -> beforeEach -> - @rclient.rpush = sinon.stub().callsArgWith(1, null, @project_update_list_length) @RedisManager.getDocVersion.withArgs(@doc_id).yields(null, @version) @RedisManager.updateDocument @project_id, @doc_id, @lines, @version, [], @ranges, @updateMeta, @callback @@ -503,7 +501,7 @@ describe "RedisManager", -> .should.equal false it "should not try to enqueue project updates", -> - @rclient.rpush + @ProjectHistoryRedisManager.queueOps .called .should.equal false