From e632f9f29d3a3ebaf7a8893923456dd22fa1d3e3 Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Thu, 11 Jul 2019 11:11:11 +0100 Subject: [PATCH] only create per-client metrics when there are multiple redis clients --- .../app/coffee/DocumentUpdaterController.coffee | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/services/real-time/app/coffee/DocumentUpdaterController.coffee b/services/real-time/app/coffee/DocumentUpdaterController.coffee index a7d174cace..ddd5702b54 100644 --- a/services/real-time/app/coffee/DocumentUpdaterController.coffee +++ b/services/real-time/app/coffee/DocumentUpdaterController.coffee @@ -21,9 +21,12 @@ module.exports = DocumentUpdaterController = metrics.inc "rclient", 0.001 # global event rate metric EventLogger.debugEvent(channel, message) if settings.debugEvents > 0 DocumentUpdaterController._processMessageFromDocumentUpdater(io, channel, message) - do (i) -> - rclient.on "message", () -> - metrics.inc "rclient-#{i}", 0.001 # per client event rate metric + # create metrics for each redis instance only when we have multiple redis clients + if @rclientList.length > 1 + for rclient, i in @rclientList + do (i) -> + rclient.on "message", () -> + metrics.inc "rclient-#{i}", 0.001 # per client event rate metric _processMessageFromDocumentUpdater: (io, channel, message) -> SafeJsonParse.parse message, (error, message) ->