github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #4261 from overleaf/jpa-fake-timed-out-response

Browse source 
[ClsiManager] respond w/ status=timedout for timed out compile requests

GitOrigin-RevId: 2937355bfd8d58870509ab40c2ba19f014f82a37
This commit is contained in:
Jakob Ackermann 2021-06-24 16:56:03 +02:00 committed by Copybot
parent d6f9f70d06
commit e57be19ee3
2 changed files with 24 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
services/web/app/src/Features/Compile/ClsiManager.js
View file

@ -472,6 +472,9 @@ const ClsiManager = {
} }
ClsiManager._makeRequest(projectId, opts, (err, response, body) => { ClsiManager._makeRequest(projectId, opts, (err, response, body) => {
if (err != null) { if (err != null) {
if (err.code === 'ESOCKETTIMEDOUT') {
return callback(null, { compile: { status: 'timedout' } })
}
return callback( return callback(
new OError('failed to make request to CLSI', { new OError('failed to make request to CLSI', {
projectId, projectId,

21
services/web/test/unit/src/Compile/ClsiManagerTests.js
View file

@ -974,6 +974,27 @@ describe('ClsiManager', function () {
this.callback.should.have.been.calledWith(sinon.match.instanceOf(Error)) this.callback.should.have.been.calledWith(sinon.match.instanceOf(Error))
}) })
}) })
describe('when the CLSI request times out', function () {
beforeEach(function () {
this.ClsiManager._makeRequest = sinon
.stub()
.callsArgWith(2, { code: 'ESOCKETTIMEDOUT' }, null, null)
this.ClsiManager._postToClsi(
this.project_id,
this.user_id,
this.req,
'standard',
this.callback
)
})
it('should call the callback with a timed out response', function () {
this.callback.should.have.been.calledWith(null, {
compile: { status: 'timedout' },
})
})
})
}) })
describe('wordCount', function () { describe('wordCount', function () {