From e421b6550a0a3ab3b60bff0e3a3a3e6cbe4dc203 Mon Sep 17 00:00:00 2001 From: Paulo Reis Date: Wed, 5 Jul 2017 11:44:05 +0100 Subject: [PATCH] Filter out read-only users from TC users list. --- services/web/app/views/project/editor/review-panel.pug | 2 +- .../review-panel/controllers/ReviewPanelController.coffee | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/services/web/app/views/project/editor/review-panel.pug b/services/web/app/views/project/editor/review-panel.pug index e4af5c2aa8..f6b4066250 100644 --- a/services/web/app/views/project/editor/review-panel.pug +++ b/services/web/app/views/project/editor/review-panel.pug @@ -77,7 +77,7 @@ on-toggle="toggleTrackChangesForUser(isOn, project.owner._id);" disabled="reviewPanel.trackChangesOnForEveryone || !project.features.trackChanges || !permissions.write" ) - li.rp-tc-state-item(ng-repeat="member in project.members") + li.rp-tc-state-item(ng-repeat="member in project.members | filter:{ privileges: 'readAndWrite' }") span.rp-tc-state-item-name( ng-class="{ 'rp-tc-state-item-name-disabled' : reviewPanel.trackChangesOnForEveryone}" style="color: hsl({{ users[member._id].hue }}, 70%, 40%);" diff --git a/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee b/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee index f0d8c113fd..51a69fca70 100644 --- a/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee +++ b/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee @@ -613,13 +613,6 @@ define [ data.on_for[userId] = userState.value data._csrf = window.csrfToken $http.post "/project/#{$scope.project_id}/track_changes", data - - # setTrackChangesState = (state) -> - # if $scope.project.features.trackChanges - # applyClientTrackChangesStateToServer() - # event_tracking.sendMB "rp-trackchanges-toggle", { state } - # else - # $scope.openTrackChangesUpgradeModal() applyTrackChangesStateToClient = (state) -> if typeof state is "boolean"