From e2d87f48211a7a1263b340b176642064a234865c Mon Sep 17 00:00:00 2001 From: Liangjun Song <146005915+adai26@users.noreply.github.com> Date: Tue, 30 Jul 2024 10:01:55 +0100 Subject: [PATCH] Revert "Revert "log clsi concurrency (#19651)" (#19655)" (#19656) This reverts commit 3719f468a6336ff4bf5126f3e5d79dcde172b7ea. GitOrigin-RevId: 6f4809f3c607c62892fc1e110eeaa2a1e7a124a4 --- services/clsi/app/js/LockManager.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/services/clsi/app/js/LockManager.js b/services/clsi/app/js/LockManager.js index 0ecd04356e..21abb43a2a 100644 --- a/services/clsi/app/js/LockManager.js +++ b/services/clsi/app/js/LockManager.js @@ -1,6 +1,7 @@ const logger = require('@overleaf/logger') const Errors = require('./Errors') const RequestParser = require('./RequestParser') +const Metrics = require('@overleaf/metrics') // The lock timeout should be higher than the maximum end-to-end compile time. // Here, we use the maximum compile timeout plus 2 minutes. @@ -19,6 +20,8 @@ function acquire(key) { } } + Metrics.gauge('concurrent_compile_requests', LOCKS.size) + const lock = new Lock(key) LOCKS.set(key, lock) return lock @@ -39,6 +42,9 @@ class Lock { if (!lockWasActive) { logger.error({ key: this.key }, 'Lock was released twice') } + if (this.isExpired()) { + Metrics.inc('compile_lock_expired_before_release') + } } }