From e27abe56b8b3a08aa0e8ff46f3868e88ee32669f Mon Sep 17 00:00:00 2001
From: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
Date: Mon, 8 Jan 2024 13:07:20 +0100
Subject: [PATCH] Show argument completions even if it has more than 245 chars
 (#16352)

* Show argument completions even if it has more than 255 chars

* use tokenBefore for existingKeys

* use 'ShortArg' token so braces are escaped

* refactor argument completion logic

* remove extra filter

* Add makeMultipleArgumentCompletionSource for arguments with multiple keys

* revert makeArgumentCompletionSource

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: f5aa70fe5e58e04efe0c4e8668957f61a7fa7911
---
 .../source-editor/languages/latex/complete.ts | 49 +++++++++++++++----
 1 file changed, 40 insertions(+), 9 deletions(-)

diff --git a/services/web/frontend/js/features/source-editor/languages/latex/complete.ts b/services/web/frontend/js/features/source-editor/languages/latex/complete.ts
index 9e44550b74..db8cd73e18 100644
--- a/services/web/frontend/js/features/source-editor/languages/latex/complete.ts
+++ b/services/web/frontend/js/features/source-editor/languages/latex/complete.ts
@@ -92,12 +92,7 @@ export function getCompletionDetails(
 
   command = command.toLowerCase()
 
-  const existingKeys = existing
-    ? existing
-        .split(',')
-        .map(key => key.trim())
-        .filter(Boolean)
-    : []
+  const existingKeys = existing ? splitExistingKeys(existing) : []
 
   const from =
     matchBefore.from + (before?.length || 0) + (existing?.length || 0)
@@ -159,8 +154,44 @@ export const makeArgumentCompletionSource = (
   return ifIn(ifInSpec, completionSource)
 }
 
+const splitExistingKeys = (text: string) =>
+  text
+    .split(',')
+    .map(key => key.trim())
+    .filter(Boolean)
+
+export const makeMultipleArgumentCompletionSource = (
+  ifInSpec: string[],
+  builder: (
+    builderOptions: Pick<
+      CompletionBuilderOptions,
+      'completions' | 'context' | 'existingKeys' | 'from' | 'validFor'
+    >
+  ) => CompletionResult | null
+): CompletionSource => {
+  const completionSource: CompletionSource = (context: CompletionContext) => {
+    const token = context.tokenBefore(ifInSpec)
+
+    if (!token) {
+      return null
+    }
+
+    // match multiple comma-separated arguments, up to the last separator
+    const existing = token.text.match(/^\{(.+\s*,\s*)?.*$/)?.[1] ?? ''
+
+    return builder({
+      completions: blankCompletions(),
+      context,
+      existingKeys: splitExistingKeys(existing),
+      from: token.from + 1 + existing.length,
+      validFor: /[^}\s]*/,
+    })
+  }
+  return ifIn(ifInSpec, completionSource)
+}
+
 export const bibKeyArgumentCompletionSource: CompletionSource =
-  makeArgumentCompletionSource(
+  makeMultipleArgumentCompletionSource(
     ['BibKeyArgument'],
     ({ completions, context, from, validFor, existingKeys }) => {
       buildReferenceCompletions(completions, context)
@@ -176,7 +207,7 @@ export const bibKeyArgumentCompletionSource: CompletionSource =
   )
 
 export const refArgumentCompletionSource: CompletionSource =
-  makeArgumentCompletionSource(
+  makeMultipleArgumentCompletionSource(
     ['RefArgument'],
     ({ completions, context, from, validFor, existingKeys }) => {
       buildLabelCompletions(completions, context)
@@ -192,7 +223,7 @@ export const refArgumentCompletionSource: CompletionSource =
   )
 
 export const packageArgumentCompletionSource: CompletionSource =
-  makeArgumentCompletionSource(
+  makeMultipleArgumentCompletionSource(
     ['PackageArgument'],
     ({ completions, context, from, validFor, existingKeys }) => {
       buildPackageCompletions(completions, context)