From e20c93b581cca05439a698285d0b6fcd6bc948df Mon Sep 17 00:00:00 2001 From: Jessica Lawshe Date: Mon, 7 Oct 2019 10:21:04 -0500 Subject: [PATCH] Merge pull request #2203 from overleaf/jel-registration-institution-sso Registration request with an institution email GitOrigin-RevId: c544d8af4f6ca91addb638e02e9fe26acad7fbdb --- .../web/app/src/Features/Project/ProjectEntityHandler.js | 2 +- services/web/app/src/Features/V1/V1Api.js | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/services/web/app/src/Features/Project/ProjectEntityHandler.js b/services/web/app/src/Features/Project/ProjectEntityHandler.js index f0bcfaf680..1ba1012c96 100644 --- a/services/web/app/src/Features/Project/ProjectEntityHandler.js +++ b/services/web/app/src/Features/Project/ProjectEntityHandler.js @@ -333,7 +333,7 @@ const ProjectEntityHandler = { return callback(err) } if (project == null) { - return callback(Errors.NotFoundError('no project')) + return callback(new Errors.NotFoundError('no project')) } return ProjectEntityHandler._getAllFoldersFromProject(project, callback) }) diff --git a/services/web/app/src/Features/V1/V1Api.js b/services/web/app/src/Features/V1/V1Api.js index a0e93ee2ae..e0516ce9ec 100644 --- a/services/web/app/src/Features/V1/V1Api.js +++ b/services/web/app/src/Features/V1/V1Api.js @@ -74,6 +74,14 @@ module.exports = V1Api = { error = new Errors.ForbiddenError('overleaf v1 returned forbidden') error.statusCode = response.statusCode return callback(error) + } else if (response.statusCode === 404) { + error = new Errors.NotFoundError( + `overleaf v1 returned non-success code: ${response.statusCode} ${ + options.method + } ${options.uri}` + ) + error.statusCode = response.statusCode + return callback(error) } else { error = new Error( `overleaf v1 returned non-success code: ${response.statusCode} ${