github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Add in guard for long messages

Browse source
This commit is contained in:
James Allen 2017-02-14 11:43:50 +01:00
parent a23919754f
commit dfe16d28a5
2 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/chat/app/coffee/Features/Messages/MessageHttpController.coffee
View file

@ -7,6 +7,7 @@ ThreadManager = require "../Threads/ThreadManager"
module.exports = MessageHttpController =
DEFAULT_MESSAGE_LIMIT: 50
MAX_MESSAGE_LENGTH: 10 * 1024 # 10kb, about 1,500 words
getGlobalMessages: (req, res, next) ->
MessageHttpController._getMessages(ThreadManager.GLOBAL_THREAD, req, res, next)
@ -76,6 +77,10 @@ module.exports = MessageHttpController =
{project_id} = req.params
if !ObjectId.isValid(user_id)
return res.send(400, "Invalid user_id")
if !content?
return res.send(400, "No content provided")
if content.length > @MAX_MESSAGE_LENGTH
return res.send(400, "Content too long (> #{@MAX_MESSAGE_LENGTH} bytes)")
logger.log {client_thread_id, project_id, user_id, content}, "new message received"
ThreadManager.findOrCreateThread project_id, client_thread_id, (error, thread) ->
return next(error) if error?

15
services/chat/test/acceptance/coffee/SendingAMessageTests.coffee
View file

@ -66,4 +66,19 @@ describe "Sending a message", ->
ChatClient.sendMessage @project_id, "malformed-thread-id", @user_id, "content", (error, response, body) =>
expect(response.statusCode).to.equal 400
expect(body).to.equal "Invalid thread_id"
done()
describe "with no content", ->
it "should return a graceful error", (done) ->
ChatClient.sendMessage @project_id, @thread_id, @user_id, null, (error, response, body) =>
expect(response.statusCode).to.equal 400
expect(body).to.equal "No content provided"
done()
describe "with very long content", ->
it "should return a graceful error", (done) ->
content = new Buffer(10240).toString("hex")
ChatClient.sendMessage @project_id, @thread_id, @user_id, content, (error, response, body) =>
expect(response.statusCode).to.equal 400
expect(body).to.equal "Content too long (> 10240 bytes)"
done()