github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

remove the path in the message from fs errors

Browse source
This commit is contained in:
Brian Gough 2018-11-06 08:36:54 +00:00
parent adb081f556
commit df3b889f50
2 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libraries/logger/logging-manager.coffee
View file

@ -50,6 +50,10 @@ module.exports = Logger =
for own key, value of error
newError[key] = value
error = newError
# filter paths from the message to avoid duplicate errors in sentry
# (e.g. errors from `fs` methods which have a path attribute)
try
error.message = error.message.replace(" '#{error.path}'", '') if error.path
# send the error to sentry
try
@raven.captureException(error, {tags: tags, extra: extra, level: level})

6
libraries/logger/test/unit/coffee/loggingManagerTests.coffee
View file

@ -40,6 +40,12 @@ describe 'logger.error', ->
@logger.error {bar: error2}, "second message"
@captureException.callCount.should.equal 2
it 'should remove the path from fs errors', () ->
fsError = new Error("Error: ENOENT: no such file or directory, stat '/tmp/3279b8d0-da10-11e8-8255-efd98985942b'")
fsError.path = "/tmp/3279b8d0-da10-11e8-8255-efd98985942b"
@logger.error {err: fsError}, "message"
@captureException.calledWith(sinon.match.has('message', 'Error: ENOENT: no such file or directory, stat')).should.equal true
it 'for multiple errors should only report a maximum of 5 errors to sentry', () ->
@logger.error {foo:'bar'}, "message"
@logger.error {foo:'bar'}, "message"