github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #14622 from overleaf/td-em-resize-observer-error

Browse source 
Prevent ResizeObserver errors from PDF viewer wrapper

GitOrigin-RevId: 3ea652e0ab4387a21ef2d3adb694129fca3c1909
This commit is contained in:
Tim Down 2023-09-05 15:46:51 +01:00 committed by Copybot
parent 5cce9683fa
commit df393a3b9a
1 changed files with 16 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
services/web/frontend/js/features/pdf-preview/util/pdf-js-wrapper.js
View file

@ -139,17 +139,24 @@ export default class PDFJSWrapper {
return return
} }
const currentScaleValue = this.viewer.currentScaleValue // Use requestAnimationFrame to prevent errors like "ResizeObserver loop
// completed with undelivered notifications" that can occur if updating the
// viewer causes another repaint. The cost of this is that the viewer update
// lags one frame behind, but it's unlikely to matter.
// Further reading: https://github.com/WICG/resize-observer/issues/38
window.requestAnimationFrame(() => {
const currentScaleValue = this.viewer.currentScaleValue
if ( if (
currentScaleValue === 'auto' || currentScaleValue === 'auto' ||
currentScaleValue === 'page-fit' || currentScaleValue === 'page-fit' ||
currentScaleValue === 'page-width' currentScaleValue === 'page-width'
) { ) {
this.viewer.currentScaleValue = currentScaleValue this.viewer.currentScaleValue = currentScaleValue
} }
this.viewer.update() this.viewer.update()
})
} }
// get the page and offset of a click event // get the page and offset of a click event