github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #20728 from overleaf/dp-state-field-error

Browse source 
Safeguard against addCommentStateField not existing

GitOrigin-RevId: 06f5f72bc12552b9668892a50d9789d6dfc45a9e
This commit is contained in:
David 2024-10-02 12:57:38 +01:00 committed by Copybot
parent aba4694377
commit df2e3c1119
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
services/web/frontend/js/features/review-panel-new/components/review-panel-current-file.tsx
View file

@ -147,7 +147,7 @@ const ReviewPanelCurrentFile: FC = () => {
const positionsRef = useRef<Map<string, number>>(new Map()) const positionsRef = useRef<Map<string, number>>(new Map())
const addCommentRanges = state.field(addCommentStateField).ranges const addCommentRanges = state.field(addCommentStateField, false)?.ranges
useEffect(() => { useEffect(() => {
if (aggregatedRanges) { if (aggregatedRanges) {
@ -178,6 +178,10 @@ const ReviewPanelCurrentFile: FC = () => {
} }
} }
if (!addCommentRanges) {
return
}
const cursor = addCommentRanges.iter() const cursor = addCommentRanges.iter()
while (cursor.value) { while (cursor.value) {
@ -212,6 +216,10 @@ const ReviewPanelCurrentFile: FC = () => {
) )
const addCommentEntries = useMemo(() => { const addCommentEntries = useMemo(() => {
if (!addCommentRanges) {
return []
}
const cursor = addCommentRanges.iter() const cursor = addCommentRanges.iter()
const entries = [] const entries = []