github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-02-16 22:31:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #11355 from overleaf/em-delete-project-no-chunks

Browse source 
Fix crash when there are no chunks to delete

GitOrigin-RevId: 3cdb77da16fe2922888e40e469740579bc4a9b8b
This commit is contained in:
Eric Mc Sween 2023-01-20 09:10:30 -05:00 committed by Copybot
parent 8227199dcb
commit ddf14b0cdd
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
services/history-v1/storage/lib/chunk_store/postgres.js
View file

@ -199,7 +199,6 @@ async function deleteChunk(projectId, chunkId) {
async function deleteProjectChunks(projectId) { async function deleteProjectChunks(projectId) {
projectId = parseInt(projectId, 10) projectId = parseInt(projectId, 10)
assert.integer(projectId, 'bad projectId') assert.integer(projectId, 'bad projectId')
assert.integer(projectId, 'bad projectId')
knex.transaction(async tx => { knex.transaction(async tx => {
await _deleteChunks(knex, { doc_id: projectId }) await _deleteChunks(knex, { doc_id: projectId })
@ -208,6 +207,9 @@ async function deleteProjectChunks(projectId) {
async function _deleteChunks(tx, whereClause) { async function _deleteChunks(tx, whereClause) {
const rows = await tx('chunks').returning('*').where(whereClause).del() const rows = await tx('chunks').returning('*').where(whereClause).del()
if (rows.length === 0) {
return
}
const oldChunks = rows.map(row => ({ const oldChunks = rows.map(row => ({
doc_id: row.doc_id, doc_id: row.doc_id,