diff --git a/package-lock.json b/package-lock.json index e0b4db5619..3627e57436 100644 --- a/package-lock.json +++ b/package-lock.json @@ -43293,6 +43293,7 @@ "@overleaf/logger": "*", "@overleaf/metrics": "*", "@overleaf/o-error": "*", + "@overleaf/promise-utils": "*", "@overleaf/redis-wrapper": "*", "@overleaf/settings": "*", "@overleaf/stream-utils": "^0.1.0", @@ -53704,6 +53705,7 @@ "@overleaf/logger": "*", "@overleaf/metrics": "*", "@overleaf/o-error": "*", + "@overleaf/promise-utils": "*", "@overleaf/redis-wrapper": "*", "@overleaf/settings": "*", "@overleaf/stream-utils": "^0.1.0", diff --git a/services/web/app/src/Features/SplitTests/SplitTestManager.js b/services/web/app/src/Features/SplitTests/SplitTestManager.js index 665840e8da..d54423c46a 100644 --- a/services/web/app/src/Features/SplitTests/SplitTestManager.js +++ b/services/web/app/src/Features/SplitTests/SplitTestManager.js @@ -106,7 +106,6 @@ async function createSplitTest( const splitTest = new SplitTest({ name: (name || '').trim(), description: info.description, - expectedEndDate: info.expectedEndDate, ticketUrl: info.ticketUrl, reportsUrls: info.reportsUrls, winningVariant: info.winningVariant, @@ -122,6 +121,9 @@ async function createSplitTest( author: userId, }, ], + expectedEndDate: info.expectedEndDate, + expectedUplift: info.expectedUplift, + requiredCohortSize: info.requiredCohortSize, }) return _saveSplitTest(splitTest) } diff --git a/services/web/app/src/models/SplitTest.js b/services/web/app/src/models/SplitTest.js index 167fce9a41..2168db4750 100644 --- a/services/web/app/src/models/SplitTest.js +++ b/services/web/app/src/models/SplitTest.js @@ -130,6 +130,14 @@ const SplitTestSchema = new Schema( type: Date, required: false, }, + requiredCohortSize: { + type: Number, + required: false, + }, + expectedUplift: { + type: Number, + required: false, + }, ticketUrl: { type: String, required: false, diff --git a/services/web/frontend/stylesheets/modules/admin-panel.less b/services/web/frontend/stylesheets/modules/admin-panel.less index a14793ca3f..e1f57a4738 100644 --- a/services/web/frontend/stylesheets/modules/admin-panel.less +++ b/services/web/frontend/stylesheets/modules/admin-panel.less @@ -17,3 +17,21 @@ max-height: calc(100vh - 40vh); overflow-y: auto; } + +.hr-sect { + display: flex; + flex-basis: 100%; + align-items: center; + color: rgba(0, 0, 0, 0.35); + margin: 8px 0; +} +.hr-sect:before, +.hr-sect:after { + content: ''; + flex-grow: 1; + background: rgba(0, 0, 0, 0.35); + height: 1px; + font-size: 0; + line-height: 0; + margin: 0 8px; +}