From dd7e6f0612a8de51fc795918490ccf63b926d45b Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Fri, 29 Sep 2017 10:49:45 +0100 Subject: [PATCH] Make class names more consistent & switch to JS targeting through id --- services/web/app/views/project/editor/editor.pug | 2 +- .../public/coffee/ide/AutoCompileOnboardingController.coffee | 2 +- .../web/public/stylesheets/app/editor/feature-onboarding.less | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/services/web/app/views/project/editor/editor.pug b/services/web/app/views/project/editor/editor.pug index f9621987b8..40734e8632 100644 --- a/services/web/app/views/project/editor/editor.pug +++ b/services/web/app/views/project/editor/editor.pug @@ -95,7 +95,7 @@ div.full-size( ) include ./pdf -.onboarding__autocompile.popover( +#onboarding-autocompile.onboarding-autocompile.popover( ng-controller="AutoCompileOnboardingController" ng-if="onboarding.autoCompile == 'show'" ng-class="placement" diff --git a/services/web/public/coffee/ide/AutoCompileOnboardingController.coffee b/services/web/public/coffee/ide/AutoCompileOnboardingController.coffee index aecfcb395a..80ba7de814 100644 --- a/services/web/public/coffee/ide/AutoCompileOnboardingController.coffee +++ b/services/web/public/coffee/ide/AutoCompileOnboardingController.coffee @@ -3,7 +3,7 @@ define [ ], (App) -> App.controller "AutoCompileOnboardingController", ($scope, event_tracking) -> recompileBtn = angular.element('#recompile') - popover = angular.element('.onboarding__autocompile') + popover = angular.element('#onboarding-autocompile') { top, left } = recompileBtn.offset() # If pdf panel smaller than recompile button + popover, show to left. diff --git a/services/web/public/stylesheets/app/editor/feature-onboarding.less b/services/web/public/stylesheets/app/editor/feature-onboarding.less index 134001b212..80c21e26c3 100644 --- a/services/web/public/stylesheets/app/editor/feature-onboarding.less +++ b/services/web/public/stylesheets/app/editor/feature-onboarding.less @@ -100,7 +100,7 @@ a.feat-onboard-dismiss { } } -.onboarding__autocompile { +.onboarding-autocompile { display: block; top: 10px;