github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #5064 from overleaf/ab-analytics-smoke-check

Browse source 
Add null check for smoke test user in analytics manager

GitOrigin-RevId: 2ece12f1a674943577ecee272435df535225ec9e
This commit is contained in:
Alexandre Bourdin 2021-09-10 15:20:49 +02:00 committed by Copybot
parent 3577f25ba2
commit dd018be499
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
services/web/app/src/Features/Analytics/AnalyticsManager.js
View file

@ -178,7 +178,11 @@ function _setUserProperty({ analyticsId, propertyName, propertyValue }) {
function _isSmokeTestUser(userId) { function _isSmokeTestUser(userId) {
const smokeTestUserId = Settings.smokeTest && Settings.smokeTest.userId const smokeTestUserId = Settings.smokeTest && Settings.smokeTest.userId
return smokeTestUserId != null && userId.toString() === smokeTestUserId return (
smokeTestUserId != null &&
userId != null &&
userId.toString() === smokeTestUserId
)
} }
function _isAnalyticsDisabled() { function _isAnalyticsDisabled() {