From dc937f4bc8fa6f00fa51db9b325fcfbdce155c25 Mon Sep 17 00:00:00 2001 From: Rebeka Dekany <50901361+rebekadekany@users.noreply.github.com> Date: Fri, 15 Sep 2023 09:14:01 +0200 Subject: [PATCH] Merge pull request #14819 from overleaf/rd-report-link-purpose Accessibility - make view togglers and download button accessible GitOrigin-RevId: 792cec60d953db7928e30dc7e7187deba59573d0 --- .../pdf-preview/components/pdf-hybrid-download-button.tsx | 1 + services/web/frontend/js/ide/directives/layout.js | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/services/web/frontend/js/features/pdf-preview/components/pdf-hybrid-download-button.tsx b/services/web/frontend/js/features/pdf-preview/components/pdf-hybrid-download-button.tsx index bc3501693e..c56792656f 100644 --- a/services/web/frontend/js/features/pdf-preview/components/pdf-hybrid-download-button.tsx +++ b/services/web/frontend/js/features/pdf-preview/components/pdf-hybrid-download-button.tsx @@ -38,6 +38,7 @@ function PdfHybridDownloadButton() { href={pdfDownloadUrl || '#'} target="_blank" style={{ pointerEvents: 'auto' }} + aria-label={t('download_pdf')} > diff --git a/services/web/frontend/js/ide/directives/layout.js b/services/web/frontend/js/ide/directives/layout.js index 802b6a88ac..2fb5da1f3e 100644 --- a/services/web/frontend/js/ide/directives/layout.js +++ b/services/web/frontend/js/ide/directives/layout.js @@ -213,7 +213,8 @@ class=\"custom-toggler ${`custom-toggler-${customTogglerPane}`}\" \ ng-class=\"isOpen ? 'custom-toggler-open' : 'custom-toggler-closed'\" \ tooltip=\"{{ isOpen ? tooltipMsgWhenOpen : tooltipMsgWhenClosed }}\" \ tooltip-placement=\"{{ tooltipPlacement }}\" \ -ng-click=\"handleClick()\">\ +ng-click=\"handleClick()\" \ +aria-label=\"{{ isOpen ? tooltipMsgWhenOpen : tooltipMsgWhenClosed }}\">\ `)(customTogglerScope) element.append(customTogglerEl) }