github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #170 from overleaf/jpa-import-141

Browse source 
[DockerRunner] destroyOldContainers: fix a race confition
This commit is contained in:
Brian Gough 2020-06-02 09:04:59 +01:00 committed by GitHub
commit d9265b779f
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
services/clsi/app/js/DockerRunner.js
View file

@ -642,6 +642,9 @@ module.exports = DockerRunner = {
ttl ttl
) { ) {
if (name.slice(0, 9) === '/project-' && ttl <= 0) { if (name.slice(0, 9) === '/project-' && ttl <= 0) {
// strip the / prefix
// the LockManager uses the plain container name
name = name.slice(1)
return jobs.push(cb => return jobs.push(cb =>
DockerRunner.destroyContainer(name, id, false, () => cb()) DockerRunner.destroyContainer(name, id, false, () => cb())
) )

6
services/clsi/test/unit/js/DockerRunnerTests.js
View file

@ -688,19 +688,19 @@ describe('DockerRunner', function() {
it('should destroy old containers', function() { it('should destroy old containers', function() {
this.DockerRunner.destroyContainer.callCount.should.equal(1) this.DockerRunner.destroyContainer.callCount.should.equal(1)
return this.DockerRunner.destroyContainer return this.DockerRunner.destroyContainer
.calledWith('/project-old-container-name', 'old-container-id') .calledWith('project-old-container-name', 'old-container-id')
.should.equal(true) .should.equal(true)
}) })
it('should not destroy new containers', function() { it('should not destroy new containers', function() {
return this.DockerRunner.destroyContainer return this.DockerRunner.destroyContainer
.calledWith('/project-new-container-name', 'new-container-id') .calledWith('project-new-container-name', 'new-container-id')
.should.equal(false) .should.equal(false)
}) })
it('should not destroy non-project containers', function() { it('should not destroy non-project containers', function() {
return this.DockerRunner.destroyContainer return this.DockerRunner.destroyContainer
.calledWith('/totally-not-a-project-container', 'some-random-id') .calledWith('totally-not-a-project-container', 'some-random-id')
.should.equal(false) .should.equal(false)
}) })