github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #695 from sharelatex/sk-fix-validation-on-refresh-output-file

Browse source 
Fix validation of project-output-file, no build_id when imported from v1
This commit is contained in:
Alberto Fernández-Capel 2018-07-03 13:38:59 +01:00 committed by GitHub
commit d904622b05
2 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
services/web/app/coffee/Features/LinkedFiles/ProjectOutputFileAgent.coffee
View file

@ -93,11 +93,17 @@ module.exports = ProjectOutputFileAgent = {
_getSourceProject: LinkedFilesHandler.getSourceProject
_validate: (data) ->
return (
(data.source_project_id? || data.v1_source_doc_id?) &&
data.source_output_file_path? &&
data.build_id?
)
if data.v1_source_doc_id?
(
data.v1_source_doc_id? &&
data.source_output_file_path?
)
else
(
data.source_project_id? &&
data.source_output_file_path? &&
data.build_id?
)
_checkAuth: (project_id, data, current_user_id, callback = (err, allowed)->) ->
callback = _.once(callback)

3
services/web/test/acceptance/coffee/LinkedFilesTests.coffee
View file

@ -428,8 +428,7 @@ describe "LinkedFiles", ->
linkedFileData: {
provider: "project_output_file",
v1_source_doc_id: 9999999, # We won't find this id in the database
source_output_file_path: "project.pdf",
build_id: '123'
source_output_file_path: "project.pdf"
},
_id: "abcdef",
rev: 0,