From d701c1ef5ec26a5242ebefe74a884c44037865dc Mon Sep 17 00:00:00 2001 From: Paulo Reis Date: Wed, 11 Jan 2017 11:25:18 +0000 Subject: [PATCH] Make the dropdown scrollable. --- .../views/project/editor/review-panel.jade | 2 +- .../stylesheets/app/editor/review-panel.less | 23 ++++++++++++------- 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/services/web/app/views/project/editor/review-panel.jade b/services/web/app/views/project/editor/review-panel.jade index 5da0fe5eaf..8d92ede03f 100644 --- a/services/web/app/views/project/editor/review-panel.jade +++ b/services/web/app/views/project/editor/review-panel.jade @@ -270,7 +270,7 @@ script(type='text/ng-template', id='resolvedCommentsDropdownTemplate') ) .rp-loading(ng-if="isLoading") i.fa.fa-spinner.fa-spin - div( + .resolved-comments-scroller( ng-if="!isLoading" ) resolved-comment-entry( diff --git a/services/web/public/stylesheets/app/editor/review-panel.less b/services/web/public/stylesheets/app/editor/review-panel.less index 1092fc2eb2..47784df152 100644 --- a/services/web/public/stylesheets/app/editor/review-panel.less +++ b/services/web/public/stylesheets/app/editor/review-panel.less @@ -103,12 +103,12 @@ align-items: center; padding: 0 5px; } - .rp-state-current-file & { - position: absolute; - top: 0; - left: 0; - right: 0; - } + // .rp-state-current-file & { + // position: absolute; + // top: 0; + // left: 0; + // right: 0; + // } height: @rp-toolbar-height; border-bottom: 1px solid @rp-border-grey; background-color: @rp-bg-dim-blue; @@ -706,11 +706,13 @@ position: absolute; width: 300px; left: -150px; + max-height: 90%; margin-top: @rp-entry-arrow-width * 1.5; margin-left: 1em; background-color: @rp-bg-blue; text-align: left; - padding: 5px; + align-items: stretch; + justify-content: center; border-radius: 3px; box-shadow: 0 0 20px 10px rgba(0, 0, 0, .3); @@ -723,6 +725,11 @@ } &-open { - display: block; + display: flex; } } + .resolved-comments-scroller { + flex: 0 0 100%; + padding: 5px; + overflow-y: auto; + }