github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #18424 from overleaf/ii-delete-with-body-fe

Browse source 
[web] Replace delete with post requests when having body (FE)

GitOrigin-RevId: df727f35ea77eaa8273687f75aafd9bd983b7f25
This commit is contained in:
ilkin-overleaf 2024-05-20 16:36:22 +03:00 committed by Copybot
parent 7ca9a5b61b
commit d56f5a3030
2 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/frontend/js/features/project-list/util/api.ts
View file

@ -42,7 +42,7 @@ export function removeProjectFromTag(tagId: string, projectId: string) {
} }
export function removeProjectsFromTag(tagId: string, projectIds: string[]) { export function removeProjectsFromTag(tagId: string, projectIds: string[]) {
return deleteJSON(`/tag/${tagId}/projects`, { return postJSON(`/tag/${tagId}/projects/remove`, {
body: { body: {
projectIds, projectIds,
}, },

17
services/web/test/frontend/features/project-list/components/project-list-root.test.tsx
View file

@ -682,8 +682,8 @@ describe('<ProjectListRoot />', function () {
}) })
it('opens the tags dropdown and remove a tag from selected projects', async function () { it('opens the tags dropdown and remove a tag from selected projects', async function () {
const deleteProjectsFromTagMock = fetchMock.delete( const deleteProjectsFromTagMock = fetchMock.post(
`express:/tag/:id/projects`, `express:/tag/:id/projects/remove`,
{ {
status: 204, status: 204,
} }
@ -702,11 +702,14 @@ describe('<ProjectListRoot />', function () {
await fetchMock.flush(true) await fetchMock.flush(true)
expect( expect(
deleteProjectsFromTagMock.called(`/tag/${this.tagId}/projects`, { deleteProjectsFromTagMock.called(
body: { `/tag/${this.tagId}/projects/remove`,
projectIds: [projectsData[0].id, projectsData[1].id], {
}, body: {
}) projectIds: [projectsData[0].id, projectsData[1].id],
},
}
)
).to.be.true ).to.be.true
screen.getByRole('button', { name: `${this.tagName} (0)` }) screen.getByRole('button', { name: `${this.tagName} (0)` })
}) })