Merge pull request #3490 from overleaf/as-remove-eslint-disables

Remove empty eslint disable comments GitOrigin-RevId: 5a0f3a5a9e4f20fdd8138ecc8c929a7587ccef66
2025-04-05 22:01:38 +00:00 · 2020-12-16 10:41:04 +00:00 · 2020-12-16 10:41:04 +00:00 · d487ffea5c
commit d487ffea5c
parent 7cbf2cdd9e
23 changed files with 19 additions and 64 deletions
--- a/services/web/frontend/js/directives/equals.js
+++ b/services/web/frontend/js/directives/equals.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
@ -14,7 +12,7 @@ export default App.directive('equals', () => ({
  link(scope, elem, attrs, ctrl) {
    const firstField = `#${attrs.equals}`
    return elem.add(firstField).on('keyup', () =>
-      scope.$apply(function () {
+      scope.$apply(function() {
        const equal = elem.val() === $(firstField).val()
        return ctrl.$setValidity('areEqual', equal)
      })
--- a/services/web/frontend/js/directives/expandableTextArea.js
+++ b/services/web/frontend/js/directives/expandableTextArea.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
@ -12,7 +10,7 @@ import App from '../base'
 export default App.directive('expandableTextArea', () => ({
  restrict: 'A',
  link(scope, el) {
-    const resetHeight = function () {
+    const resetHeight = function() {
      const curHeight = el.outerHeight()
      const fitHeight = el.prop('scrollHeight')
      // clear height if text area is empty
--- a/services/web/frontend/js/directives/fineUpload.js
+++ b/services/web/frontend/js/directives/fineUpload.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
@ -42,12 +40,12 @@ export default App.directive('fineUpload', $timeout => ({
      validation.sizeLimit = scope.sizeLimit
    }
    const maxConnections = scope.maxConnections || 1
-    const onComplete = scope.onCompleteCallback || function () {}
-    const onUpload = scope.onUploadCallback || function () {}
-    const onError = scope.onErrorCallback || function () {}
-    const onValidateBatch = scope.onValidateBatch || function () {}
-    const onSubmit = scope.onSubmitCallback || function () {}
-    const onCancel = scope.onCancelCallback || function () {}
+    const onComplete = scope.onCompleteCallback || function() {}
+    const onUpload = scope.onUploadCallback || function() {}
+    const onError = scope.onErrorCallback || function() {}
+    const onValidateBatch = scope.onValidateBatch || function() {}
+    const onSubmit = scope.onSubmitCallback || function() {}
+    const onCancel = scope.onCancelCallback || function() {}
    if (scope.autoUpload == null) {
      autoUpload = true
    } else {
--- a/services/web/frontend/js/directives/maxHeight.js
+++ b/services/web/frontend/js/directives/maxHeight.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
@ -13,7 +11,7 @@ import App from '../base'
 export default App.directive('maxHeight', () => ({
  restrict: 'A',
  link(scope, element, attrs) {
-    return scope.$watch(attrs.maxHeight, function (value) {
+    return scope.$watch(attrs.maxHeight, function(value) {
      if (value != null) {
        return element.css({ 'max-height': value })
      }
--- a/services/web/frontend/js/directives/onEnter.js
+++ b/services/web/frontend/js/directives/onEnter.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
@ -10,7 +8,7 @@
 import App from '../base'

 export default App.directive('onEnter', () => (scope, element, attrs) =>
-  element.bind('keydown keypress', function (event) {
+  element.bind('keydown keypress', function(event) {
    if (event.which === 13) {
      scope.$apply(() => scope.$eval(attrs.onEnter, { event }))
      return event.preventDefault()
--- a/services/web/frontend/js/directives/rightClick.js
+++ b/services/web/frontend/js/directives/rightClick.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
@ -12,7 +10,7 @@ import App from '../base'
 export default App.directive('rightClick', () => ({
  restrict: 'A',
  link(scope, element, attrs) {
-    return element.bind('contextmenu', function (e) {
+    return element.bind('contextmenu', function(e) {
      e.preventDefault()
      e.stopPropagation()
      return scope.$eval(attrs.rightClick)
--- a/services/web/frontend/js/filters/formatDate.js
+++ b/services/web/frontend/js/filters/formatDate.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
@ -24,7 +22,7 @@ moment.updateLocale('en', {
 App.filter(
  'formatDate',
  () =>
-    function (date, format) {
+    function(date, format) {
      if (!date) return 'N/A'
      if (format == null) {
        format = 'Do MMM YYYY, h:mm a'
--- a/services/web/frontend/js/ide/clone/index.js
+++ b/services/web/frontend/js/ide/clone/index.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 import './controllers/CloneProjectController'
--- a/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/snippets/Environments.js
+++ b/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/snippets/Environments.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 const envs = [
--- a/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/snippets/TopHundredSnippets.js
+++ b/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/snippets/TopHundredSnippets.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
--- a/services/web/frontend/js/ide/file-tree/directives/draggable.js
+++ b/services/web/frontend/js/ide/file-tree/directives/draggable.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
@ -11,7 +9,7 @@ import App from '../../../base'

 export default App.directive('draggable', () => ({
  link(scope, element, attrs) {
-    return scope.$watch(attrs.draggable, function (draggable) {
+    return scope.$watch(attrs.draggable, function(draggable) {
      if (draggable) {
        return element.draggable({
          delay: 250,
--- a/services/web/frontend/js/ide/file-tree/directives/droppable.js
+++ b/services/web/frontend/js/ide/file-tree/directives/droppable.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
@ -11,7 +9,7 @@ import App from '../../../base'

 export default App.directive('droppable', () => ({
  link(scope, element, attrs) {
-    return scope.$watch(attrs.droppable, function (droppable) {
+    return scope.$watch(attrs.droppable, function(droppable) {
      if (droppable) {
        return element.droppable({
          greedy: true,
--- a/services/web/frontend/js/ide/history/components/historyFileTree.js
+++ b/services/web/frontend/js/ide/history/components/historyFileTree.js
@ -1,6 +1,5 @@
 import _ from 'lodash'
-/* eslint-disable
- */
+
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
@ -9,12 +8,12 @@ import _ from 'lodash'
 * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
 */
 import App from '../../../base'
-const historyFileTreeController = function ($scope, $element, $attrs) {
+const historyFileTreeController = function($scope, $element, $attrs) {
  const ctrl = this
  ctrl.handleEntityClick = file => ctrl.onSelectedFileChange({ file })
  ctrl._fileTree = []

-  $scope.$watch('$ctrl.files', function (files) {
+  $scope.$watch('$ctrl.files', function(files) {
    if (files != null && files.length > 0) {
      ctrl._fileTree = _.reduce(files, _reducePathsToTree, [])
    }
--- a/services/web/frontend/js/ide/hotkeys/index.js
+++ b/services/web/frontend/js/ide/hotkeys/index.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 import './BackspaceHighjack'
--- a/services/web/frontend/js/ide/review-panel/ReviewPanelManager.js
+++ b/services/web/frontend/js/ide/review-panel/ReviewPanelManager.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 import './controllers/ReviewPanelController'
--- a/services/web/frontend/js/ide/review-panel/filters/notEmpty.js
+++ b/services/web/frontend/js/ide/review-panel/filters/notEmpty.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
--- a/services/web/frontend/js/ide/review-panel/filters/numKeys.js
+++ b/services/web/frontend/js/ide/review-panel/filters/numKeys.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
@ -13,7 +11,7 @@ import App from '../../../base'
 export default App.filter(
  'numKeys',
  () =>
-    function (object) {
+    function(object) {
      if (object != null) {
        return Object.keys(object).length
      } else {
--- a/services/web/frontend/js/ide/review-panel/filters/orderOverviewEntries.js
+++ b/services/web/frontend/js/ide/review-panel/filters/orderOverviewEntries.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
@ -12,7 +10,7 @@ import App from '../../../base'
 export default App.filter(
  'orderOverviewEntries',
  () =>
-    function (items) {
+    function(items) {
      const array = []
      for (let key in items) {
        const value = items[key]
--- a/services/web/frontend/js/ide/settings/index.js
+++ b/services/web/frontend/js/ide/settings/index.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 import './services/settings'
--- a/services/web/frontend/js/ide/wordcount/index.js
+++ b/services/web/frontend/js/ide/wordcount/index.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 import './controllers/WordCountController'
--- a/services/web/frontend/js/main/keys.js
+++ b/services/web/frontend/js/main/keys.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
--- a/services/web/frontend/js/main/project-list/index.js
+++ b/services/web/frontend/js/main/project-list/index.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 import './project-list'
--- a/services/web/frontend/js/main/scribtex-popup.js
+++ b/services/web/frontend/js/main/scribtex-popup.js
@ -1,5 +1,3 @@
-/* eslint-disable
- */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*