github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #20404 from overleaf/revert-20389-jdt-add-writefull-commons-to-v1

Browse source 
Revert "Add writefull commons to v1"

GitOrigin-RevId: 703e2873cb64059f6a3881d6fc7f3c475caf5abd
This commit is contained in:
Jimmy Domagala-Tang 2024-09-16 15:08:04 +01:00 committed by Copybot
parent aca9466c49
commit d41e069c69
5 changed files with 1 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
services/web/frontend/js/features/project-list/components/notifications/writefull-premium-promo-banner.tsx
View file

@ -4,7 +4,6 @@ import { sendMB } from '@/infrastructure/event-tracking'
import customLocalStorage from '@/infrastructure/local-storage'
import WritefullLogo from '@/shared/svgs/writefull-logo'
import OLButton from '@/features/ui/components/ol/ol-button'
import getMeta from '@/utils/meta'
const eventSegmentation = {
location: 'dashboard-banner',
@ -21,11 +20,6 @@ function WritefullPremiumPromoBanner({
setShow: (value: boolean) => void
onDismiss: () => void
}) {
// dont show the add to WF commons users since their license already includes it
const userAffiliations = getMeta('ol-userAffiliations') || []
const hasWritefullCommons = userAffiliations.some(
affil => affil.institution?.writefullCommonsAccount
)
const handleClose = useCallback(() => {
customLocalStorage.setItem('has_dismissed_writefull_promo_banner', true)
setShow(false)
@ -33,7 +27,7 @@ function WritefullPremiumPromoBanner({
onDismiss()
}, [setShow, onDismiss])
if (!show || hasWritefullCommons) {
if (!show) {
return null
}

1
services/web/test/frontend/features/settings/components/emails/emails-section-add-new-email.test.tsx
View file

@ -23,7 +23,6 @@ const userEmailData: UserEmailData & { affiliation: Affiliation } = {
department: 'Art History',
institution: {
commonsAccount: false,
writefullCommonsAccount: false,
confirmed: true,
id: 1,
isUniversity: true,

2
services/web/test/frontend/features/settings/components/emails/emails-section-institution-and-role.test.tsx
View file

@ -23,7 +23,6 @@ const userData1: UserEmailData & { affiliation: Affiliation } = {
department: null,
institution: {
commonsAccount: false,
writefullCommonsAccount: false,
confirmed: true,
id: 1,
isUniversity: false,
@ -54,7 +53,6 @@ const userData2: UserEmailData & { affiliation: Affiliation } = {
department: 'Art History',
institution: {
commonsAccount: false,
writefullCommonsAccount: false,
confirmed: true,
id: 1,
isUniversity: false,

3
services/web/test/frontend/features/settings/fixtures/test-user-email-data.ts
View file

@ -24,7 +24,6 @@ export const professionalUserData: UserEmailData & {
department: 'Art History',
institution: {
commonsAccount: false,
writefullCommonsAccount: false,
confirmed: true,
id: 1,
isUniversity: false,
@ -57,7 +56,6 @@ export const unconfirmedCommonsUserData: UserEmailData & {
department: 'Art History',
institution: {
commonsAccount: true,
writefullCommonsAccount: false,
confirmed: true,
id: 1,
isUniversity: false,
@ -87,7 +85,6 @@ export const ssoUserData: UserEmailData = {
department: 'Art History',
institution: {
commonsAccount: true,
writefullCommonsAccount: false,
confirmed: true,
id: 2,
isUniversity: true,

1
services/web/types/institution.ts
View file

@ -2,7 +2,6 @@ import { Nullable } from './utils'
export type Institution = {
commonsAccount: boolean
writefullCommonsAccount: boolean
confirmed: boolean
id: number
isUniversity: boolean