From 9f966996be24f286af3b84d11d54a09b2bfc91f8 Mon Sep 17 00:00:00 2001 From: James Allen Date: Tue, 1 Apr 2014 12:53:16 +0100 Subject: [PATCH] Monkey patch request in smoke tests to work around secnding secure cookie over HTTP --- services/web/test/smoke/coffee/SmokeTests.coffee | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/services/web/test/smoke/coffee/SmokeTests.coffee b/services/web/test/smoke/coffee/SmokeTests.coffee index 85cbb895b9..7bee88fce9 100644 --- a/services/web/test/smoke/coffee/SmokeTests.coffee +++ b/services/web/test/smoke/coffee/SmokeTests.coffee @@ -1,18 +1,23 @@ chai = require("chai") chai.should() expect = chai.expect -request = require "request" Settings = require "settings-sharelatex" +# Monkey patch request cookies, because the new tough-cookie module +# assumes it's not a secure cookie if the url is not HTTPS +request = require "request" +jar = request.jar() +jar.getCookieString = (uri) -> + return @_jar.getCookieStringSync uri, secure: true +request = request.defaults jar: jar + port = Settings.internal?.web?.port or Settings.port or 3000 buildUrl = (path) -> "http://localhost:#{port}/#{path}" describe "Opening", -> before (done) -> - @jar = request.jar() request.get { url: buildUrl("register") - jar: @jar headers: "X-Forwarded-Proto": "https" }, (error, response, body) => @@ -23,7 +28,6 @@ describe "Opening", -> email: Settings.smokeTest.user password: Settings.smokeTest.password _csrf: csrf - jar: @jar headers: "X-Forwarded-Proto": "https" }, (error, response, body) -> @@ -33,7 +37,6 @@ describe "Opening", -> it "a project", (done) -> request { url: buildUrl("project/#{Settings.smokeTest.projectId}") - jar: @jar headers: "X-Forwarded-Proto": "https" }, (error, response, body) -> @@ -47,7 +50,6 @@ describe "Opening", -> it "the project list", (done) -> request { url: buildUrl("project") - jar: @jar headers: "X-Forwarded-Proto": "https" }, (error, response, body) ->