From d2289379cd2ea87744248db24c4a49ea7c8710ff Mon Sep 17 00:00:00 2001 From: David <33458145+davidmcpowell@users.noreply.github.com> Date: Mon, 5 Aug 2024 14:22:23 +0100 Subject: [PATCH] Merge pull request #19633 from overleaf/dp-tooltip-colour Update styling for math-preview tooltip in dark editor themes GitOrigin-RevId: bfd02793d1438cfeee173210f57b1fbb4c28ccc3 --- .../source-editor/extensions/math-preview.ts | 21 ++++++++++++++++++- .../stylesheets/app/editor/math-preview.less | 3 --- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/services/web/frontend/js/features/source-editor/extensions/math-preview.ts b/services/web/frontend/js/features/source-editor/extensions/math-preview.ts index 831a8ab8ad..d9c03065bf 100644 --- a/services/web/frontend/js/features/source-editor/extensions/math-preview.ts +++ b/services/web/frontend/js/features/source-editor/extensions/math-preview.ts @@ -1,4 +1,5 @@ import { + EditorView, repositionTooltips, showTooltip, Tooltip, @@ -29,7 +30,9 @@ export const mathPreview = (enabled: boolean): Extension => { return [] } - return mathPreviewConf.of(enabled ? mathPreviewStateField : []) + return mathPreviewConf.of( + enabled ? [mathPreviewTheme, mathPreviewStateField] : [] + ) } const mathPreviewConf = new Compartment() @@ -162,3 +165,19 @@ const buildTooltipContent = ( return element } + +/** + * Styles for the preview tooltip + */ +const mathPreviewTheme = EditorView.baseTheme({ + '&light .ol-cm-math-tooltip': { + boxShadow: '0px 2px 4px 0px #1e253029', + border: '1px solid #e7e9ee !important', + backgroundColor: 'white !important', + }, + '&dark .ol-cm-math-tooltip': { + boxShadow: '0px 2px 4px 0px #1e253029', + border: '1px solid #2f3a4c !important', + backgroundColor: '#1b222c !important', + }, +}) diff --git a/services/web/frontend/stylesheets/app/editor/math-preview.less b/services/web/frontend/stylesheets/app/editor/math-preview.less index e4bbbda2b8..aea2df3179 100644 --- a/services/web/frontend/stylesheets/app/editor/math-preview.less +++ b/services/web/frontend/stylesheets/app/editor/math-preview.less @@ -1,8 +1,5 @@ .ol-cm-math-tooltip { - box-shadow: 0px 2px 4px 0px #1e253029; - border: 1px solid #e7e9ee !important; border-radius: 4px; - background-color: white !important; max-height: 400px; max-width: 800px; overflow: auto;