github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

removed mkdirp dependency and replaced with fs.mkdir

Browse source
This commit is contained in:
mserranom 2020-03-12 10:22:08 +01:00
parent 35f69e4f8b
commit cf6c8ab496
4 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
services/clsi/app/js/ResourceWriter.js
View file

@ -19,7 +19,6 @@ const UrlCache = require('./UrlCache')
const Path = require('path')
const fs = require('fs')
const async = require('async')
const mkdirp = require('mkdirp')
const OutputFileFinder = require('./OutputFileFinder')
const ResourceStateManager = require('./ResourceStateManager')
const Metrics = require('./Metrics')
@ -302,7 +301,7 @@ module.exports = ResourceWriter = {
if (error != null) {
return callback(error)
}
return mkdirp(Path.dirname(path), function(error) {
return fs.mkdir(Path.dirname(path), { recursive: true }, function(error) {
if (error != null) {
return callback(error)
}

5
services/clsi/package-lock.json generated
View file

@ -3953,11 +3953,6 @@
"minipass": "^2.2.1"
}
},
"mkdirp": {
"version": "1.0.3",
"resolved": "https://registry.npmjs.org/mkdirp/-/mkdirp-1.0.3.tgz",
"integrity": "sha512-6uCP4Qc0sWsgMLy1EOqqS/3rjDHOEnsStVr/4vtAIK2Y5i2kA7lFFejYrpIyiN9w0pYf4ckeCYT9f1r1P9KX5g=="
},
"mocha": {
"version": "4.1.0",
"resolved": "https://registry.npmjs.org/mocha/-/mocha-4.1.0.tgz",

1
services/clsi/package.json
View file

@ -29,7 +29,6 @@
"logger-sharelatex": "^1.9.0",
"lynx": "0.2.0",
"metrics-sharelatex": "^2.5.1",
"mkdirp": "1.0.3",
"mysql": "^2.18.1",
"request": "^2.88.2",
"sequelize": "^4.44.4",

7
services/clsi/test/unit/js/ResourceWriterTests.js
View file

@ -31,7 +31,6 @@ describe('ResourceWriter', function() {
'./ResourceStateManager': (this.ResourceStateManager = {}),
wrench: (this.wrench = {}),
'./UrlCache': (this.UrlCache = {}),
mkdirp: (this.mkdirp = sinon.stub().callsArg(1)),
'./OutputFileFinder': (this.OutputFileFinder = {}),
'logger-sharelatex': { log: sinon.stub(), err: sinon.stub() },
'./Metrics': (this.Metrics = {
@ -346,6 +345,7 @@ describe('ResourceWriter', function() {
describe('_writeResourceToDisk', function() {
describe('with a url based resource', function() {
beforeEach(function() {
this.fs.mkdir = sinon.stub().callsArg(2)
this.resource = {
path: 'main.tex',
url: 'http://www.example.com/main.tex',
@ -363,7 +363,7 @@ describe('ResourceWriter', function() {
})
it('should ensure the directory exists', function() {
return this.mkdirp
this.fs.mkdir
.calledWith(
path.dirname(path.join(this.basePath, this.resource.path))
)
@ -397,6 +397,7 @@ describe('ResourceWriter', function() {
content: 'Hello world'
}
this.fs.writeFile = sinon.stub().callsArg(2)
this.fs.mkdir = sinon.stub().callsArg(2)
return this.ResourceWriter._writeResourceToDisk(
this.project_id,
this.resource,
@ -406,7 +407,7 @@ describe('ResourceWriter', function() {
})
it('should ensure the directory exists', function() {
return this.mkdirp
return this.fs.mkdir
.calledWith(
path.dirname(path.join(this.basePath, this.resource.path))
)