github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

Remove the email when user id is added to project

Browse source
This commit is contained in:
Shane Kilkelly 2016-08-11 14:17:01 +01:00
parent 826295167f
commit ce039f8cd3
2 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/web/app/coffee/Features/Collaborators/CollaboratorsHandler.coffee
View file

@ -130,11 +130,6 @@ module.exports = CollaboratorsHandler =
else else
return callback(new Error("unknown privilegeLevel: #{privilegeLevel}")) return callback(new Error("unknown privilegeLevel: #{privilegeLevel}"))
# Do these in the background
UserGetter.getUser user_id, {email: 1}, (error, user) ->
if error?
logger.error {err: error, project_id, user_id}, "error getting user while adding to project"
CollaboratorsEmailHandler.notifyUserOfProjectShare project_id, user.email
ContactManager.addContact adding_user_id, user_id ContactManager.addContact adding_user_id, user_id
Project.update { _id: project_id }, { $addToSet: level }, (error) -> Project.update { _id: project_id }, { $addToSet: level }, (error) ->

2
services/web/test/UnitTests/coffee/Collaborators/CollaboratorsHandlerTests.coffee
View file

@ -180,8 +180,6 @@ describe "CollaboratorsHandler", ->
@Project.findOne = sinon.stub().callsArgWith(2, null, @project = {}) @Project.findOne = sinon.stub().callsArgWith(2, null, @project = {})
@ProjectEntityHandler.flushProjectToThirdPartyDataStore = sinon.stub().callsArg(1) @ProjectEntityHandler.flushProjectToThirdPartyDataStore = sinon.stub().callsArg(1)
@CollaboratorHandler.addEmailToProject = sinon.stub().callsArgWith(4, null, @user_id) @CollaboratorHandler.addEmailToProject = sinon.stub().callsArgWith(4, null, @user_id)
@UserGetter.getUser = sinon.stub().callsArgWith(2, null, @user = { _id: @user_id, email: @email })
@CollaboratorsEmailHandler.notifyUserOfProjectShare = sinon.stub()
@ContactManager.addContact = sinon.stub() @ContactManager.addContact = sinon.stub()
describe "as readOnly", -> describe "as readOnly", ->