From aa1f2cc8a90aa73723e2e09f96ccf191a589d77f Mon Sep 17 00:00:00 2001 From: James Allen Date: Tue, 22 Mar 2016 12:11:59 +0000 Subject: [PATCH 1/2] Remove #s in href on project list buttons --- .../app/views/project/list/project-list.jade | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/services/web/app/views/project/list/project-list.jade b/services/web/app/views/project/list/project-list.jade index 9e8c22a1e8..649c860b26 100644 --- a/services/web/app/views/project/list/project-list.jade +++ b/services/web/app/views/project/list/project-list.jade @@ -24,7 +24,7 @@ .btn-toolbar(ng-show="filter != 'archived'") .btn-group(ng-hide="selectedProjects.length < 1") a.btn.btn-default( - href='#', + href, tooltip="#{translate('download')}", tooltip-placement="bottom", tooltip-append-to-body="true", @@ -32,7 +32,7 @@ ) i.fa.fa-cloud-download a.btn.btn-default( - href='#', + href, tooltip="#{translate('delete')}", tooltip-placement="bottom", tooltip-append-to-body="true", @@ -42,7 +42,7 @@ .btn-group.dropdown(ng-hide="selectedProjects.length < 1", dropdown) a.btn.btn-default.dropdown-toggle( - href="#", + href, data-toggle="dropdown", dropdown-toggle, tooltip="#{translate('add_to_folders')}", @@ -72,11 +72,11 @@ | {{tag.name}} li.divider li - a(href="#", ng-click="openNewTagModal()", stop-propagation="click") #{translate("create_new_folder")} + a(href, ng-click="openNewTagModal()", stop-propagation="click") #{translate("create_new_folder")} .btn-group(ng-hide="selectedProjects.length != 1", dropdown).dropdown a.btn.btn-default.dropdown-toggle( - href='#', + href, data-toggle="dropdown", dropdown-toggle ) #{translate("more")} @@ -84,19 +84,19 @@ ul.dropdown-menu.dropdown-menu-right(role="menu") li(ng-show="getFirstSelectedProject().accessLevel == 'owner'") a( - href='#', + href, ng-click="openRenameProjectModal()" ) #{translate("rename")} li a( - href='#', + href, ng-click="openCloneProjectModal()" ) #{translate("make_copy")} .btn-toolbar(ng-show="filter == 'archived'") .btn-group(ng-hide="selectedProjects.length < 1") a.btn.btn-default( - href='#', + href, data-original-title="Restore", data-toggle="tooltip", data-placement="bottom", @@ -105,7 +105,7 @@ .btn-group(ng-hide="selectedProjects.length < 1") a.btn.btn-danger( - href='#', + href, data-original-title="Delete Forever", data-toggle="tooltip", data-placement="bottom", From 4595c9036363f3ec18494f726e27a4cfcb636b01 Mon Sep 17 00:00:00 2001 From: James Allen Date: Tue, 22 Mar 2016 12:12:11 +0000 Subject: [PATCH 2/2] Use translations for action in project delete modal --- services/web/app/views/project/list/modals.jade | 4 +++- .../coffee/main/project-list/modal-controllers.coffee | 6 +++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/services/web/app/views/project/list/modals.jade b/services/web/app/views/project/list/modals.jade index e0fe24ad14..4f66507289 100644 --- a/services/web/app/views/project/list/modals.jade +++ b/services/web/app/views/project/list/modals.jade @@ -183,7 +183,9 @@ script(type='text/ng-template', id='deleteProjectsModalTemplate') data-dismiss="modal" ng-click="cancel()" ) × - h3 {{action}} #{translate("projects")} + h3(ng-if="action == 'delete'") #{translate("delete_projects")} + h3(ng-if="action == 'leave'") #{translate("leave_projects")} + h3(ng-if="action == 'delete-and-leave'") #{translate("delete_and_leave_projects")} .modal-body div(ng-show="projectsToDelete.length > 0") p #{translate("about_to_delete_projects")} diff --git a/services/web/public/coffee/main/project-list/modal-controllers.coffee b/services/web/public/coffee/main/project-list/modal-controllers.coffee index a841e369a8..dbf3c613ac 100644 --- a/services/web/public/coffee/main/project-list/modal-controllers.coffee +++ b/services/web/public/coffee/main/project-list/modal-controllers.coffee @@ -65,11 +65,11 @@ define [ $scope.projectsToLeave = projects.filter (project) -> project.accessLevel != "owner" if $scope.projectsToLeave.length > 0 and $scope.projectsToDelete.length > 0 - $scope.action = "Delete & Leave" + $scope.action = "delete-and-leave" else if $scope.projectsToLeave.length == 0 and $scope.projectsToDelete.length > 0 - $scope.action = "Delete" + $scope.action = "delete" else - $scope.action = "Leave" + $scope.action = "leave" $scope.delete = () -> $modalInstance.close()