github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #408 from sharelatex/ja-track-changes

Browse source 
Clear selection after creating a comment
This commit is contained in:
James Allen 2017-02-07 08:55:39 +01:00 committed by GitHub
commit c97ded201f
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
services/web/public/coffee/ide/editor/directives/aceEditor/cursor-position/CursorPositionManager.coffee
View file

@ -37,6 +37,9 @@ define [
@gotoOffset(offset) @gotoOffset(offset)
, 10 # Hack: Must happen after @gotoStoredPosition , 10 # Hack: Must happen after @gotoStoredPosition
@$scope.$on "#{@$scope.name}:clearSelection", (e) =>
@editor.selection.clearSelection()
storeScrollTopPosition: (session) -> storeScrollTopPosition: (session) ->
if @doc_id? if @doc_id?
docPosition = @localStorage("doc.position.#{@doc_id}") || {} docPosition = @localStorage("doc.position.#{@doc_id}") || {}

1
services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee
View file

@ -306,6 +306,7 @@ define [
$http.post("/project/#{$scope.project_id}/thread/#{thread_id}/messages", {content, _csrf: window.csrfToken}) $http.post("/project/#{$scope.project_id}/thread/#{thread_id}/messages", {content, _csrf: window.csrfToken})
.error (error) -> .error (error) ->
ide.showGenericMessageModal("Error submitting comment", "Sorry, there was a problem submitting your comment") ide.showGenericMessageModal("Error submitting comment", "Sorry, there was a problem submitting your comment")
$scope.$broadcast "editor:clearSelection"
$timeout () -> $timeout () ->
$scope.$broadcast "review-panel:layout" $scope.$broadcast "review-panel:layout"
event_tracking.sendMB "rp-new-comment", { size: content.length } event_tracking.sendMB "rp-new-comment", { size: content.length }