github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-29 08:33:33 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #5709 from overleaf/ae-fail-prop-types-tests

Browse source 
Format error messages for test failure

GitOrigin-RevId: 74da66d9da31939755162a91f5adf4f8122f06f6
This commit is contained in:
Alf Eaton 2021-11-15 15:44:06 +00:00 committed by Copybot
parent 642764fccf
commit c73894e56b
3 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
services/web/test/frontend/features/editor-navigation-toolbar/components/toolbar-header.test.js
View file

@ -18,6 +18,9 @@ describe('<ToolbarHeader />', function () {
togglePdfView: () => {}, togglePdfView: () => {},
hasPublishPermissions: true, hasPublishPermissions: true,
trackChangesVisible: true, trackChangesVisible: true,
handleChangeLayout: () => {},
pdfLayout: '',
view: '',
} }
describe('cobranding logo', function () { describe('cobranding logo', function () {

8
services/web/test/frontend/features/outline/components/outline-pane.test.js
View file

@ -76,7 +76,13 @@ describe('<OutlinePane />', function () {
}) })
it('expand outline and use local storage', function () { it('expand outline and use local storage', function () {
global.localStorage.getItem.returns(false) global.localStorage.getItem.callsFake(key => {
if (key.startsWith('file_outline.expanded.')) {
return false
}
return null
})
const outline = [ const outline = [
{ {
title: 'Section', title: 'Section',

8
services/web/test/frontend/prop-types.test.js
View file

@ -1,3 +1,5 @@
import { format } from 'util'
/** /**
* Make tests fail when prop-types are incorrect. * Make tests fail when prop-types are incorrect.
* *
@ -14,10 +16,12 @@ before(function () {
// Ensure we still log the error // Ensure we still log the error
originalConsoleError(message, ...args) originalConsoleError(message, ...args)
const formattedMessage = format(message, ...args)
// Check if the error is from prop-types // Check if the error is from prop-types
if (/Failed (prop|data) type/.test(message)) { if (/Failed (prop|data) type/.test(formattedMessage)) {
// Throw an error, causing the test to fail // Throw an error, causing the test to fail
throw new Error(message) throw new Error(formattedMessage)
} }
} }
}) })