github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-12-26 04:01:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

[RedisManager] block inserting of too large docs into redis

Browse source
This commit is contained in:
Jakob Ackermann 2021-05-06 17:19:23 +01:00
parent a4ae0ea12f
commit c707d0b345
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
services/document-updater/app/js/RedisManager.js
View file

@ -72,6 +72,13 @@ module.exports = RedisManager = {
logger.error({ err: error, doc_id, docLines }, error.message) logger.error({ err: error, doc_id, docLines }, error.message)
return callback(error) return callback(error)
} }
// Do a cheap size check on the serialized blob.
if (docLines.length > Settings.max_doc_length) {
const docSize = docLines.length
const err = new Error('blocking doc insert into redis: doc is too large')
logger.error({ project_id, doc_id, err, docSize }, err.message)
return callback(err)
}
const docHash = RedisManager._computeHash(docLines) const docHash = RedisManager._computeHash(docLines)
// record bytes sent to redis // record bytes sent to redis
metrics.summary('redis.docLines', docLines.length, { status: 'set' }) metrics.summary('redis.docLines', docLines.length, { status: 'set' })