github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

use null instead of err in callbacks on success

Browse source
This commit is contained in:
Brian Gough 2017-07-12 10:47:23 +01:00
parent d2730c8d6b
commit c21cc013f3
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
services/document-updater/app/coffee/LockManager.coffee
View file

@ -46,11 +46,11 @@ module.exports = LockManager =
return callback(err) if err? # error freeing lock
callback null, false # tell caller they didn't get the lock
else
callback err, true, lockValue
callback null, true, lockValue
else
metrics.inc "doc-blocking"
profile.log("doc is locked").end()
callback err, false
callback null, false
getLock: (doc_id, callback = (error, lockValue) ->) ->
startTime = Date.now()
@ -81,10 +81,10 @@ module.exports = LockManager =
exists = parseInt exists
if exists == 1
metrics.inc "doc-blocking"
callback err, false
callback null, false
else
metrics.inc "doc-not-blocking"
callback err, true
callback null, true
releaseLock: (doc_id, lockValue, callback)->
key = keys.blockingKey(doc_id:doc_id)
@ -99,4 +99,4 @@ module.exports = LockManager =
return callback(new Error("tried to release timed out lock"))
else
profile.log("unlockScript:ok").end()
callback(err,result)
callback(null,result)