github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

Updates to the AI error assistant (#19065)

Browse source 
* Only show the AI error assistant to users with write permission on the project
* Fix line number in searchDocLines
* Abort the request after 60 seconds
* Move comment
* Jump to file + line when suggestion line number is clicked
* Set tool_choice: 'required'
* Fix handling of suggestLineChange
* Tidy up getDocLines
* Avoid showing Suggest Fix button in gutter marker for typesetting warnings
* Log request errors
* Fix prefixed function name
* Update tool description
* Tweak the prompt in an attempt to improve the line number
* Reject if the total message content is too large
* Change the structure of the suggested change
* Reduce line highlight
* Fix change highlighting on deletion

GitOrigin-RevId: afde096e547050b8518195ef51b68983bc3b0be3
This commit is contained in:
Alf Eaton 2024-06-24 12:25:58 +01:00 committed by Copybot
parent 1697087425
commit bee698c01d
2 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
services/web/app/src/Features/Project/ProjectController.js
View file

@ -544,7 +544,9 @@ const _ProjectController = {
const showAiErrorAssistant = const showAiErrorAssistant =
userId && userId &&
Features.hasFeature('saas') && Features.hasFeature('saas') &&
(user.features?.aiErrorAssistant || user.alphaProgram) (user.features?.aiErrorAssistant || user.alphaProgram) &&
(privilegeLevel === PrivilegeLevels.READ_AND_WRITE ||
privilegeLevel === PrivilegeLevels.OWNER)
const template = const template =
detachRole === 'detached' detachRole === 'detached'

13
services/web/frontend/js/features/pdf-preview/util/output-files.js
View file

@ -153,7 +153,7 @@ export function buildLogEntryAnnotations(entries, fileTreeData, rootDocId) {
logEntryAnnotations[entity._id] = [] logEntryAnnotations[entity._id] = []
} }
logEntryAnnotations[entity._id].push({ const annotation = {
id: entry.key, id: entry.key,
entryIndex: logEntryAnnotations[entity._id].length, // used for maintaining the order of items on the same line entryIndex: logEntryAnnotations[entity._id].length, // used for maintaining the order of items on the same line
row: entry.line - 1, row: entry.line - 1,
@ -161,12 +161,19 @@ export function buildLogEntryAnnotations(entries, fileTreeData, rootDocId) {
text: entry.message, text: entry.message,
source: 'compile', // NOTE: this is used in Ace for filtering the annotations source: 'compile', // NOTE: this is used in Ace for filtering the annotations
ruleId: entry.ruleId, ruleId: entry.ruleId,
firstOnLine: !seenLine[entry.line], }
})
// set firstOnLine for the first non-typesetting annotation on a line
if (entry.level !== 'typesetting') {
if (!seenLine[entry.line]) {
annotation.firstOnLine = true
seenLine[entry.line] = true seenLine[entry.line] = true
} }
} }
logEntryAnnotations[entity._id].push(annotation)
}
}
} }
return logEntryAnnotations return logEntryAnnotations