github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

[misc] RoomManagerTests: explicitly pass a cb to joinProject/joinDoc

Browse source
This commit is contained in:
Jakob Ackermann 2020-06-29 11:57:16 +01:00
parent 5e191be171
commit bea0e9beb7
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
services/real-time/test/unit/js/RoomManagerTests.js
View file

@ -113,7 +113,7 @@ describe('RoomManager', function () {
}) })
return describe('when there are other clients in the project room', function () { return describe('when there are other clients in the project room', function () {
beforeEach(function () { beforeEach(function (done) {
this.RoomManager._clientsInRoom this.RoomManager._clientsInRoom
.withArgs(this.client, this.project_id) .withArgs(this.client, this.project_id)
.onFirstCall() .onFirstCall()
@ -121,7 +121,7 @@ describe('RoomManager', function () {
.onSecondCall() .onSecondCall()
.returns(124) .returns(124)
this.client.join = sinon.stub() this.client.join = sinon.stub()
return this.RoomManager.joinProject(this.client, this.project_id) this.RoomManager.joinProject(this.client, this.project_id, done)
}) })
it('should join the room using the id', function () { it('should join the room using the id', function () {
@ -174,7 +174,7 @@ describe('RoomManager', function () {
}) })
return describe('when there are other clients in the doc room', function () { return describe('when there are other clients in the doc room', function () {
beforeEach(function () { beforeEach(function (done) {
this.RoomManager._clientsInRoom this.RoomManager._clientsInRoom
.withArgs(this.client, this.doc_id) .withArgs(this.client, this.doc_id)
.onFirstCall() .onFirstCall()
@ -182,7 +182,7 @@ describe('RoomManager', function () {
.onSecondCall() .onSecondCall()
.returns(124) .returns(124)
this.client.join = sinon.stub() this.client.join = sinon.stub()
return this.RoomManager.joinDoc(this.client, this.doc_id) this.RoomManager.joinDoc(this.client, this.doc_id, done)
}) })
it('should join the room using the id', function () { it('should join the room using the id', function () {