github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-29 12:23:35 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #61 from overleaf/jpa-explicit-dependencies

Browse source 
[misc] add linting for missing explicit dependencies and fix any errors
This commit is contained in:
nate stemen 2021-05-17 17:07:30 -04:00 committed by GitHub
commit bc99218596
2 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
services/contacts/.eslintrc
View file

@ -22,7 +22,10 @@
"rules": { "rules": {
// Swap the no-unused-expressions rule with a more chai-friendly one // Swap the no-unused-expressions rule with a more chai-friendly one
"no-unused-expressions": 0, "no-unused-expressions": 0,
"chai-friendly/no-unused-expressions": "error" "chai-friendly/no-unused-expressions": "error",
// Do not allow importing of implicit dependencies.
"import/no-extraneous-dependencies": "error"
}, },
"overrides": [ "overrides": [
{ {
@ -57,7 +60,13 @@
"files": ["app/**/*.js", "app.js", "index.js"], "files": ["app/**/*.js", "app.js", "index.js"],
"rules": { "rules": {
// don't allow console.log in backend code // don't allow console.log in backend code
"no-console": "error" "no-console": "error",
// Do not allow importing of implicit dependencies.
"import/no-extraneous-dependencies": ["error", {
// Do not allow importing of devDependencies.
"devDependencies": false
}]
} }
} }
] ]

2
services/contacts/buildscript.txt
View file

@ -5,4 +5,4 @@ contacts
--env-pass-through= --env-pass-through=
--node-version=12.21.0 --node-version=12.21.0
--public-repo=False --public-repo=False
--script-version=3.7.0 --script-version=3.8.0