github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

Handle read-only permissions; allow read-only users to see state but not change it.

Browse source
This commit is contained in:
Paulo Reis 2017-07-05 11:13:48 +01:00
parent 71e0a6935f
commit bc88dbd0f8
1 changed files with 4 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
services/web/app/views/project/editor/review-panel.pug
View file

@ -46,7 +46,7 @@
is-loading="reviewPanel.dropdown.loading" is-loading="reviewPanel.dropdown.loading"
permissions="permissions" permissions="permissions"
) )
span.review-panel-toolbar-label(ng-if="permissions.write") span.review-panel-toolbar-label
span.review-panel-toolbar-icon-on( span.review-panel-toolbar-icon-on(
ng-if="editor.wantTrackChanges === true" ng-if="editor.wantTrackChanges === true"
) )
@ -65,10 +65,8 @@
review-panel-toggle( review-panel-toggle(
ng-model="reviewPanel.trackChangesOnForEveryone" ng-model="reviewPanel.trackChangesOnForEveryone"
on-toggle="toggleTrackChangesForEveryone(isOn);" on-toggle="toggleTrackChangesForEveryone(isOn);"
disabled="!project.features.trackChanges" disabled="!project.features.trackChanges || !permissions.write"
) )
//- disabled="!project.features.trackChanges"
//- on-disabled-click="openTrackChangesUpgradeModal"
li.rp-tc-state-item li.rp-tc-state-item
span.rp-tc-state-item-name.rp-tc-state-item-owner( span.rp-tc-state-item-name.rp-tc-state-item-owner(
ng-class="{ 'rp-tc-state-item-name-disabled' : reviewPanel.trackChangesOnForEveryone}" ng-class="{ 'rp-tc-state-item-name-disabled' : reviewPanel.trackChangesOnForEveryone}"
@ -77,7 +75,7 @@
review-panel-toggle( review-panel-toggle(
ng-model="reviewPanel.trackChangesState[project.owner._id].value" ng-model="reviewPanel.trackChangesState[project.owner._id].value"
on-toggle="toggleTrackChangesForUser(isOn, project.owner._id);" on-toggle="toggleTrackChangesForUser(isOn, project.owner._id);"
disabled="reviewPanel.trackChangesOnForEveryone || !project.features.trackChanges" disabled="reviewPanel.trackChangesOnForEveryone || !project.features.trackChanges || !permissions.write"
) )
li.rp-tc-state-item(ng-repeat="member in project.members") li.rp-tc-state-item(ng-repeat="member in project.members")
span.rp-tc-state-item-name( span.rp-tc-state-item-name(
@ -87,24 +85,8 @@
review-panel-toggle( review-panel-toggle(
ng-model="reviewPanel.trackChangesState[member._id].value" ng-model="reviewPanel.trackChangesState[member._id].value"
on-toggle="toggleTrackChangesForUser(isOn, member._id);" on-toggle="toggleTrackChangesForUser(isOn, member._id);"
disabled="reviewPanel.trackChangesOnForEveryone || !project.features.trackChanges" disabled="reviewPanel.trackChangesOnForEveryone || !project.features.trackChanges || !permissions.write"
) )
//- span.review-panel-toolbar-label(ng-if="permissions.write")
//- span(ng-click="toggleTrackChanges(true)", ng-if="editor.wantTrackChanges === false") !{translate("track_changes_is_off")}
//- span(ng-click="toggleTrackChanges(false)", ng-if="editor.wantTrackChanges === true") !{translate("track_changes_is_on")}
//- review-panel-toggle(
//- ng-if="editor.wantTrackChanges == editor.trackChanges"
//- ng-model="editor.wantTrackChanges"
//- on-toggle="toggleTrackChanges"
//- disabled="!project.features.trackChanges"
//- on-disabled-click="openTrackChangesUpgradeModal"
//- )
//- span.review-panel-toolbar-label.review-panel-toolbar-label-disabled(ng-if="!permissions.write")
//- span(ng-if="editor.wantTrackChanges === false") !{translate("track_changes_is_off")}
//- span(ng-if="editor.wantTrackChanges === true") !{translate("track_changes_is_on")}
//- span.review-panel-toolbar-spinner(ng-if="editor.wantTrackChanges != editor.trackChanges")
//- i.fa.fa-spin.fa-spinner
.rp-entry-list( .rp-entry-list(
review-panel-sorted review-panel-sorted