github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #6255 from overleaf/jel-tidy-saml-tests

Browse source 
[web] Tidy SAML tests

GitOrigin-RevId: 3b13fa847d935235bafe61c4118b046eb972f922
This commit is contained in:
Jessica Lawshe 2022-01-12 10:19:11 -06:00 committed by Copybot
parent 4792208ed2
commit bbc5e2d34c
1 changed files with 29 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
services/web/test/unit/src/User/SAMLIdentityManagerTests.js
View file

@ -339,39 +339,38 @@ describe('SAMLIdentityManager', function () {
this.UserGetter.promises.getUser.onSecondCall().resolves(this.user)
})
it('should update the user audit log', function () {
it('should update the user audit log', async function () {
const auditLog = {
intiatorId: '6005c75b12cbcaf771f4a105',
ip: '0:0:0:0',
initiatorId: '6005c75b12cbcaf771f4a105',
ipAddress: '0:0:0:0',
}
this.SAMLIdentityManager.linkAccounts(
await this.SAMLIdentityManager.linkAccounts(
this.user._id,
'externalUserId',
this.user.email,
'1',
'Overleaf University',
undefined,
auditLog,
() => {
auditLog
)
expect(
this.UserAuditLogHandler.promises.addEntry
).to.have.been.calledWith(
this.user._id,
'link-institution-sso',
auditLog.initiatorId,
auditLog.ip,
auditLog.ipAddress,
{
institutionEmail: this.user.email,
providerId: '1',
providerName: 'Overleaf University',
}
)
}
)
})
it('should send an email notification', function () {
this.SAMLIdentityManager.linkAccounts(
it('should send an email notification', async function () {
await this.SAMLIdentityManager.linkAccounts(
this.user._id,
'externalUserId',
this.user.email,
@ -381,9 +380,10 @@ describe('SAMLIdentityManager', function () {
{
intiatorId: '6005c75b12cbcaf771f4a105',
ipAddress: '0:0:0:0',
},
() => {
expect(this.User.updateOne).to.have.been.called
}
)
expect(this.User.findOneAndUpdate).to.have.been.called
expect(this.EmailHandler.sendEmail).to.have.been.calledOnce
const emailArgs = this.EmailHandler.sendEmail.lastCall.args
expect(emailArgs[0]).to.equal('securityAlert')
@ -391,8 +391,6 @@ describe('SAMLIdentityManager', function () {
expect(emailArgs[1].actionDescribed).to.contain('was linked')
expect(emailArgs[1].message[0]).to.contain('Linked')
expect(emailArgs[1].message[0]).to.contain(this.user.email)
}
)
})
})
})