From baa57c56aa0e88175c8452a82ad1e3b59d4812a5 Mon Sep 17 00:00:00 2001
From: Paulo Reis <paulojreis@gmail.com>
Date: Thu, 21 Dec 2017 13:34:11 +0000
Subject: [PATCH] Improve dropdown spacing in v2.

---
 services/web/public/stylesheets/components/dropdowns.less   | 2 +-
 services/web/public/stylesheets/core/_common-variables.less | 4 ++++
 services/web/public/stylesheets/core/mixins.less            | 2 +-
 services/web/public/stylesheets/core/ol-variables.less      | 3 +++
 4 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/services/web/public/stylesheets/components/dropdowns.less b/services/web/public/stylesheets/components/dropdowns.less
index 7adbfe49d7..516db7178e 100755
--- a/services/web/public/stylesheets/components/dropdowns.less
+++ b/services/web/public/stylesheets/components/dropdowns.less
@@ -61,7 +61,7 @@
   // Links and other items within the dropdown menu
   > li > a,div {
     display: block;
-    padding: 3px 20px;
+    padding: @dropdown-item-padding;
     clear: both;
     font-weight: normal;
     line-height: @line-height-base;
diff --git a/services/web/public/stylesheets/core/_common-variables.less b/services/web/public/stylesheets/core/_common-variables.less
index b385a45e8e..257e1b2a04 100644
--- a/services/web/public/stylesheets/core/_common-variables.less
+++ b/services/web/public/stylesheets/core/_common-variables.less
@@ -824,6 +824,10 @@
 @navbar-subdued-hover-bg    : @gray-lightest;
 @navbar-subdued-hover-color : @gray-dark;
 
+@dropdown-divider-margin    :((@line-height-computed / 2) - 1) 0;
+@dropdown-item-padding      : 3px 20px;
+
+
 // Button colors and sizing
 @btn-border-radius-large : @border-radius-large;
 @btn-border-radius-base  : @border-radius-base;
diff --git a/services/web/public/stylesheets/core/mixins.less b/services/web/public/stylesheets/core/mixins.less
index bb5068f54d..866f081292 100755
--- a/services/web/public/stylesheets/core/mixins.less
+++ b/services/web/public/stylesheets/core/mixins.less
@@ -395,7 +395,7 @@
 // Dividers (basically an hr) within dropdowns and nav lists
 .nav-divider(@color: #e5e5e5) {
   height: 1px;
-  margin: ((@line-height-computed / 2) - 1) 0;
+  margin: @dropdown-divider-margin;
   overflow: hidden;
   background-color: @color;
 }
diff --git a/services/web/public/stylesheets/core/ol-variables.less b/services/web/public/stylesheets/core/ol-variables.less
index d2e3cdb530..ae03e06bbf 100644
--- a/services/web/public/stylesheets/core/ol-variables.less
+++ b/services/web/public/stylesheets/core/ol-variables.less
@@ -113,6 +113,9 @@
 @navbar-subdued-hover-bg          : #FFF;
 @navbar-subdued-hover-color       : @ol-green;
 
+@dropdown-divider-margin          : 6px;
+@dropdown-item-padding            : 4px 20px;
+
 // Forms
 @input-color                      : @ol-blue-gray-3;
 @input-border-radius              : unit(@line-height-base, em);