diff --git a/services/contacts/app.js b/services/contacts/app.js index 0565974c0f..759f42f0bf 100644 --- a/services/contacts/app.js +++ b/services/contacts/app.js @@ -37,9 +37,9 @@ app.get('/status', (req, res) => res.send('contacts is alive')) app.use(function (error, req, res, next) { logger.error({ err: error }, 'request errored') if (error instanceof Errors.NotFoundError) { - return res.send(404) + return res.sendStatus(404) } else { - return res.send(500, 'Oops, something went wrong') + return res.status(500).send('Oops, something went wrong') } }) diff --git a/services/contacts/app/js/HttpController.js b/services/contacts/app/js/HttpController.js index bca67671e0..691f542047 100644 --- a/services/contacts/app/js/HttpController.js +++ b/services/contacts/app/js/HttpController.js @@ -33,7 +33,7 @@ module.exports = HttpController = { if (error != null) { return next(error) } - return res.status(204).end() + return res.sendStatus(204) }) }) }, diff --git a/services/contacts/test/unit/js/HttpControllerTests.js b/services/contacts/test/unit/js/HttpControllerTests.js index 4c2e4a7695..e136f4135b 100644 --- a/services/contacts/test/unit/js/HttpControllerTests.js +++ b/services/contacts/test/unit/js/HttpControllerTests.js @@ -33,6 +33,7 @@ describe('HttpController', function () { this.res.status = sinon.stub().returns(this.res) this.res.end = sinon.stub() this.res.send = sinon.stub() + this.res.sendStatus = sinon.stub() return (this.next = sinon.stub()) }) @@ -61,8 +62,7 @@ describe('HttpController', function () { }) return it('should send back a 204 status', function () { - this.res.status.calledWith(204).should.equal(true) - return this.res.end.called.should.equal(true) + this.res.sendStatus.calledWith(204).should.equal(true) }) })