github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1211 from sharelatex/ta-fetch-v1-data-log-errors

Browse source 
Log Errors in fetchV1Data

GitOrigin-RevId: 4b709430c2ad97ca369e93eaa4c4edf5ad7f3f52
This commit is contained in:
Simon Detheridge 2018-12-03 11:05:14 +00:00 committed by sharelatex
parent aae0484458
commit b69cc6ce77
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
services/web/app/coffee/models/Institution.coffee
View file

@ -2,6 +2,7 @@ mongoose = require 'mongoose'
Schema = mongoose.Schema
ObjectId = Schema.ObjectId
settings = require 'settings-sharelatex'
logger = require 'logger-sharelatex'
request = require 'request'
InstitutionSchema = new Schema
@ -12,7 +13,10 @@ InstitutionSchema = new Schema
InstitutionSchema.method 'fetchV1Data', (callback = (error, institution)->) ->
url = "#{settings.apis.v1.url}/universities/list/#{this.v1Id}"
request.get url, (error, response, body) =>
try parsedBody = JSON.parse(body) catch e
try
parsedBody = JSON.parse(body)
catch error # log error and carry on without v1 data
logger.err { model: 'Institution', v1Id: this.v1Id, error }, '[fetchV1DataError]'
this.name = parsedBody?.name
this.countryCode = parsedBody?.country_code
this.departments = parsedBody?.departments

6
services/web/app/coffee/models/Publisher.coffee
View file

@ -2,6 +2,7 @@ mongoose = require 'mongoose'
Schema = mongoose.Schema
ObjectId = Schema.ObjectId
settings = require 'settings-sharelatex'
logger = require 'logger-sharelatex'
request = require 'request'
PublisherSchema = new Schema
@ -19,7 +20,10 @@ PublisherSchema.method 'fetchV1Data', (callback = (error, publisher)->) ->
pass: settings.apis.v1.pass
sendImmediately: true
}, (error, response, body) =>
try parsedBody = JSON.parse(body) catch e
try
parsedBody = JSON.parse(body)
catch error # log error and carry on without v1 data
logger.err { model: 'Publisher', slug: this.slug, error }, '[fetchV1DataError]'
this.name = parsedBody?.name
this.partner = parsedBody?.partner
callback(null, this)