github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #93 from overleaf/bg-flush-history-when-deleting-project

Browse source 
avoid project history queues building up with deferred flush
This commit is contained in:
Brian Gough 2019-10-03 08:37:45 +01:00 committed by GitHub
commit b63fc66588
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/document-updater/app/coffee/DeleteQueueManager.coffee
View file

@ -38,7 +38,7 @@ module.exports = DeleteQueueManager =
logger.debug {project_id, timestamps, flushTimestamp}, "found newer timestamp, will skip delete"
return cb()
logger.log {project_id, flushTimestamp}, "flushing queued project"
ProjectManager.flushAndDeleteProjectWithLocks project_id, {skip_history_flush: true}, (err) ->
ProjectManager.flushAndDeleteProjectWithLocks project_id, {skip_history_flush: false}, (err) ->
if err?
logger.err {project_id, err}, "error flushing queued project"
metrics.inc "queued-delete-completed"

4
services/document-updater/test/acceptance/coffee/DeletingAProjectTests.coffee
View file

@ -169,6 +169,6 @@ describe "Deleting a project", ->
for doc in @docs
MockTrackChangesApi.flushDoc.calledWith(doc.id).should.equal true
it "should not flush to project history", ->
MockProjectHistoryApi.flushProject.called.should.equal false
it "should flush to project history", ->
MockProjectHistoryApi.flushProject.called.should.equal true