github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #114 from sharelatex/bg-avoid-text-html-content-type-in-responses

Browse source 
use explicit json content-type to avoid security issues with text/html
This commit is contained in:
Brian Gough 2019-02-22 11:35:24 +00:00 committed by GitHub
commit b48d45f996
2 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
services/clsi/app/coffee/CompileController.coffee
View file

@ -84,7 +84,7 @@ module.exports = CompileController =
user_id = req.params.user_id
CompileManager.syncFromCode project_id, user_id, file, line, column, (error, pdfPositions) ->
return next(error) if error?
res.send JSON.stringify {
res.json {
pdf: pdfPositions
}
@ -96,7 +96,7 @@ module.exports = CompileController =
user_id = req.params.user_id
CompileManager.syncFromPdf project_id, user_id, page, h, v, (error, codePositions) ->
return next(error) if error?
res.send JSON.stringify {
res.json {
code: codePositions
}
@ -109,7 +109,7 @@ module.exports = CompileController =
CompileManager.wordcount project_id, user_id, file, image, (error, result) ->
return next(error) if error?
res.send JSON.stringify {
res.json {
texcount: result
}

18
services/clsi/test/unit/coffee/CompileControllerTests.coffee
View file

@ -144,7 +144,7 @@ describe "CompileController", ->
file: @file
line: @line.toString()
column: @column.toString()
@res.send = sinon.stub()
@res.json = sinon.stub()
@CompileManager.syncFromCode = sinon.stub().callsArgWith(5, null, @pdfPositions = ["mock-positions"])
@CompileController.syncFromCode @req, @res, @next
@ -155,8 +155,8 @@ describe "CompileController", ->
.should.equal true
it "should return the positions", ->
@res.send
.calledWith(JSON.stringify
@res.json
.calledWith(
pdf: @pdfPositions
)
.should.equal true
@ -173,7 +173,7 @@ describe "CompileController", ->
page: @page.toString()
h: @h.toString()
v: @v.toString()
@res.send = sinon.stub()
@res.json = sinon.stub()
@CompileManager.syncFromPdf = sinon.stub().callsArgWith(5, null, @codePositions = ["mock-positions"])
@CompileController.syncFromPdf @req, @res, @next
@ -184,8 +184,8 @@ describe "CompileController", ->
.should.equal true
it "should return the positions", ->
@res.send
.calledWith(JSON.stringify
@res.json
.calledWith(
code: @codePositions
)
.should.equal true
@ -199,7 +199,7 @@ describe "CompileController", ->
@req.query =
file: @file
image: @image = "example.com/image"
@res.send = sinon.stub()
@res.json = sinon.stub()
@CompileManager.wordcount = sinon.stub().callsArgWith(4, null, @texcount = ["mock-texcount"])
@CompileController.wordcount @req, @res, @next
@ -210,8 +210,8 @@ describe "CompileController", ->
.should.equal true
it "should return the texcount info", ->
@res.send
.calledWith(JSON.stringify
@res.json
.calledWith(
texcount: @texcount
)
.should.equal true