github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

reject very large ops

Browse source
This commit is contained in:
Brian Gough 2016-01-26 14:52:40 +00:00
parent b7a4c72f9c
commit b44a7b9aa6
2 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
services/track-changes/app.coffee
View file

@ -16,6 +16,7 @@ truncateFn = (updates) ->
TrackChangesLogger.addSerializers { TrackChangesLogger.addSerializers {
rawUpdates: truncateFn rawUpdates: truncateFn
newUpdates: truncateFn newUpdates: truncateFn
rawUpdate: truncateFn
lastUpdate: truncateFn lastUpdate: truncateFn
} }

11
services/track-changes/app/coffee/UpdatesManager.coffee
View file

@ -47,6 +47,17 @@ module.exports = UpdatesManager =
if rawUpdates.length == 0 if rawUpdates.length == 0
return callback() return callback()
# some old large ops in redis need to be rejected, they predate
# the size limit that now prevents them going through the system
REJECT_LARGE_OP_SIZE = 4 * 1024 * 1024
for rawUpdate in rawUpdates
opSizes = ((op.i?.length || op.d?.length) for op in rawUpdate?.op or [])
size = _.max opSizes
if size > REJECT_LARGE_OP_SIZE
error = new Error("dropped op exceeding maximum allowed size of #{REJECT_LARGE_OP_SIZE}")
logger.error err: error, doc_id: doc_id, project_id: project_id, size: size, rawUpdate: rawUpdate, "dropped op - too big"
rawUpdate.op = []
if (not lastCompressedUpdate?) or lastCompressedUpdate.pack? # handle pack append as a special case if (not lastCompressedUpdate?) or lastCompressedUpdate.pack? # handle pack append as a special case
UpdatesManager._updatePack project_id, doc_id, rawUpdates, temporary, lastCompressedUpdate, lastVersion, callback UpdatesManager._updatePack project_id, doc_id, rawUpdates, temporary, lastCompressedUpdate, lastVersion, callback
else #use the existing op code else #use the existing op code