diff --git a/services/web/app/coffee/Features/Analytics/AnalyticsController.coffee b/services/web/app/coffee/Features/Analytics/AnalyticsController.coffee index 88aa757e92..38f5a2e9a4 100644 --- a/services/web/app/coffee/Features/Analytics/AnalyticsController.coffee +++ b/services/web/app/coffee/Features/Analytics/AnalyticsController.coffee @@ -11,7 +11,7 @@ module.exports = AnalyticsController = if userId? GeoIpLookup.getDetails req.ip, (err, geoDetails) -> countryCode = geoDetails?.country_code || null - AnalyticsManager.updateEditingSession userId, projectId, countryCode, {}, (error) -> + AnalyticsManager.updateEditingSession userId, projectId, countryCode, (error) -> respondWith(error, res, next) else res.send 204 diff --git a/services/web/app/coffee/Features/Analytics/AnalyticsManager.coffee b/services/web/app/coffee/Features/Analytics/AnalyticsManager.coffee index 6bf3943c81..469183d2fa 100644 --- a/services/web/app/coffee/Features/Analytics/AnalyticsManager.coffee +++ b/services/web/app/coffee/Features/Analytics/AnalyticsManager.coffee @@ -43,7 +43,7 @@ module.exports = opts.qs = {fromV2: 1} makeRequest opts, callback - updateEditingSession: (userId, projectId, countryCode, segmentation = {}, callback = (error) ->) -> + updateEditingSession: (userId, projectId, countryCode, callback = (error) ->) -> if userId+"" == settings.smokeTest?.userId+"" return callback() query = @@ -52,9 +52,6 @@ module.exports = if countryCode query.countryCode = countryCode opts = - body: - segmentation: segmentation - json: true method: "PUT" timeout: 1000 url: "/editingSession" diff --git a/services/web/test/unit/coffee/Analytics/AnalyticsControllerTests.coffee b/services/web/test/unit/coffee/Analytics/AnalyticsControllerTests.coffee index 002940d263..c3e3802f37 100644 --- a/services/web/test/unit/coffee/Analytics/AnalyticsControllerTests.coffee +++ b/services/web/test/unit/coffee/Analytics/AnalyticsControllerTests.coffee @@ -14,7 +14,7 @@ describe 'AnalyticsController', -> getLoggedInUserId: sinon.stub() @AnalyticsManager = - updateEditingSession: sinon.stub().callsArgWith(4) + updateEditingSession: sinon.stub().callsArgWith(3) recordEvent: sinon.stub().callsArgWith(3) @controller = SandboxedModule.require modulePath, requires: @@ -43,8 +43,7 @@ describe 'AnalyticsController', -> @AnalyticsManager.updateEditingSession.calledWith( "1234", "a project id", - 'XY', - {} + 'XY' ).should.equal true done()