diff --git a/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/add-label.tsx b/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/add-label.tsx index 9281b3c391..882bb9a439 100644 --- a/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/add-label.tsx +++ b/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/add-label.tsx @@ -3,7 +3,6 @@ import { useTranslation } from 'react-i18next' import OLDropdownMenuItem from '@/features/ui/components/ol/ol-dropdown-menu-item' import OLTagIcon from '@/features/ui/components/ol/icons/ol-tag-icon' import AddLabelModal from '../../add-label-modal' -import DropdownListItem from '@/features/ui/components/bootstrap-5/dropdown-list-item' type DownloadProps = { projectId: string @@ -26,7 +25,7 @@ function AddLabel({ } return ( - + <> } @@ -41,7 +40,7 @@ function AddLabel({ setShow={setShowModal} version={version} /> - + ) } diff --git a/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/compare-dropdown-item.tsx b/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/compare-dropdown-item.tsx index 91d5507ce0..5b8d490ff9 100644 --- a/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/compare-dropdown-item.tsx +++ b/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/compare-dropdown-item.tsx @@ -2,7 +2,6 @@ import { useHistoryContext } from '../../../../context/history-context' import { UpdateRange } from '../../../../services/types/update' import { ReactNode } from 'react' import OLDropdownMenuItem from '@/features/ui/components/ol/ol-dropdown-menu-item' -import DropdownListItem from '@/features/ui/components/bootstrap-5/dropdown-list-item' type CompareProps = { comparisonRange: UpdateRange @@ -33,17 +32,15 @@ function CompareDropDownItem({ } return ( - - - {text} - - + + {text} + ) } diff --git a/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/download.tsx b/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/download.tsx index 0701ee5d07..fc3e1a2d5f 100644 --- a/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/download.tsx +++ b/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/download.tsx @@ -3,7 +3,6 @@ import OLDropdownMenuItem from '@/features/ui/components/ol/ol-dropdown-menu-ite import MaterialIcon from '@/shared/components/material-icon' import BootstrapVersionSwitcher from '@/features/ui/components/bootstrap-5/bootstrap-version-switcher' import Icon from '../../../../../../shared/components/icon' -import DropdownListItem from '@/features/ui/components/bootstrap-5/dropdown-list-item' type DownloadProps = { projectId: string @@ -20,23 +19,21 @@ function Download({ const { t } = useTranslation() return ( - - } - bs5={} - /> - } - {...props} - > - {t('history_download_this_version')} - - + } + bs5={} + /> + } + {...props} + > + {t('history_download_this_version')} + ) } diff --git a/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/restore-project.tsx b/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/restore-project.tsx index c491594db1..dad0f47cd0 100644 --- a/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/restore-project.tsx +++ b/services/web/frontend/js/features/history/components/change-list/dropdown/menu-item/restore-project.tsx @@ -9,7 +9,6 @@ import withErrorBoundary from '@/infrastructure/error-boundary' import { RestoreProjectErrorModal } from '../../../diff-view/modals/restore-project-error-modal' import MaterialIcon from '@/shared/components/material-icon' import BootstrapVersionSwitcher from '@/features/ui/components/bootstrap-5/bootstrap-version-switcher' -import DropdownListItem from '@/features/ui/components/bootstrap-5/dropdown-list-item' type RestoreProjectProps = { projectId: string @@ -46,7 +45,7 @@ const RestoreProject = ({ } return ( - + <> - + ) } diff --git a/services/web/frontend/js/features/source-editor/components/math-preview-tooltip.tsx b/services/web/frontend/js/features/source-editor/components/math-preview-tooltip.tsx index af5e762819..22d0c56e69 100644 --- a/services/web/frontend/js/features/source-editor/components/math-preview-tooltip.tsx +++ b/services/web/frontend/js/features/source-editor/components/math-preview-tooltip.tsx @@ -113,27 +113,23 @@ const MathPreviewTooltip: FC<{ mathContent: HTMLDivElement }> = ({ /> -
  • - - Esc - - } - > - {t('hide')} - -
  • -
  • - - {t('disable')} - -
  • + + Esc + + } + > + {t('hide')} + + + {t('disable')} +
    } diff --git a/services/web/frontend/js/features/ui/components/ol/ol-dropdown-menu-item.tsx b/services/web/frontend/js/features/ui/components/ol/ol-dropdown-menu-item.tsx index 84550542e6..59567ecce9 100644 --- a/services/web/frontend/js/features/ui/components/ol/ol-dropdown-menu-item.tsx +++ b/services/web/frontend/js/features/ui/components/ol/ol-dropdown-menu-item.tsx @@ -2,11 +2,13 @@ import { MenuItem, MenuItemProps } from 'react-bootstrap' import { DropdownItem } from '@/features/ui/components/bootstrap-5/dropdown-menu' import { DropdownItemProps } from '@/features/ui/components/types/dropdown-menu-props' import BootstrapVersionSwitcher from '@/features/ui/components/bootstrap-5/bootstrap-version-switcher' +import DropdownListItem from '@/features/ui/components/bootstrap-5/dropdown-list-item' type OLDropdownMenuItemProps = DropdownItemProps & { bs3Props?: MenuItemProps } +// This represents a menu item. It wraps the item within an
  • element. function OLDropdownMenuItem(props: OLDropdownMenuItemProps) { const { bs3Props, ...rest } = props @@ -30,7 +32,11 @@ function OLDropdownMenuItem(props: OLDropdownMenuItemProps) { return ( } - bs5={} + bs5={ + + + + } /> ) } diff --git a/services/web/frontend/stories/ui/dropdown-menu.stories.tsx b/services/web/frontend/stories/ui/dropdown-menu.stories.tsx index f3d9003f98..3426299cc3 100644 --- a/services/web/frontend/stories/ui/dropdown-menu.stories.tsx +++ b/services/web/frontend/stories/ui/dropdown-menu.stories.tsx @@ -141,54 +141,44 @@ export const Description = (args: Args) => { export const Icon = (args: Args) => { return ( -
  • - - Editor & PDF - -
  • -
  • - - Editor only - -
  • -
  • - - PDF only - -
  • -
  • - - PDF in separate tab - -
  • -
  • - - Small icon - -
  • + + Editor & PDF + + + Editor only + + + PDF only + + + PDF in separate tab + + + Small icon + ) }