github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-29 22:21:30 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #3628 from overleaf/ae-global-localstorage

Browse source 
Use Object.defineProperty to set global.localStorage for tests

GitOrigin-RevId: 541a253a6d19fcc93b40c74942ae8ecffb85fa60
This commit is contained in:
Miguel Serrano 2021-02-09 16:39:44 +01:00 committed by Copybot
parent ceab823447
commit b35114b81a
3 changed files with 38 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
services/web/test/frontend/bootstrap.js vendored
View file

@ -26,14 +26,19 @@ moment.updateLocale('en', {
}) })
let inMemoryLocalStorage = {} let inMemoryLocalStorage = {}
global.localStorage = { Object.defineProperty(global, 'localStorage', {
// localStorage returns `null` when the item does not exist value: {
getItem: key => // localStorage returns `null` when the item does not exist
inMemoryLocalStorage[key] !== undefined ? inMemoryLocalStorage[key] : null, getItem: key =>
setItem: (key, value) => (inMemoryLocalStorage[key] = value), inMemoryLocalStorage[key] !== undefined
clear: () => (inMemoryLocalStorage = {}), ? inMemoryLocalStorage[key]
removeItem: key => delete inMemoryLocalStorage[key] : null,
} setItem: (key, value) => (inMemoryLocalStorage[key] = value),
clear: () => (inMemoryLocalStorage = {}),
removeItem: key => delete inMemoryLocalStorage[key]
},
writable: true
})
// node-fetch doesn't accept relative URL's: https://github.com/node-fetch/node-fetch/blob/master/docs/v2-LIMITS.md#known-differences // node-fetch doesn't accept relative URL's: https://github.com/node-fetch/node-fetch/blob/master/docs/v2-LIMITS.md#known-differences
const fetch = require('node-fetch') const fetch = require('node-fetch')

17
services/web/test/frontend/features/outline/components/outline-pane.test.js
View file

@ -15,11 +15,16 @@ describe('<OutlinePane />', function() {
renderWithEditorContext(children, { projectId: '123abc' }) renderWithEditorContext(children, { projectId: '123abc' })
} }
let originalLocalStorage
before(function() { before(function() {
global.localStorage = { originalLocalStorage = global.localStorage
getItem: sinon.stub().returns(null),
setItem: sinon.stub() Object.defineProperty(global, 'localStorage', {
} value: {
getItem: sinon.stub().returns(null),
setItem: sinon.stub()
}
})
}) })
afterEach(function() { afterEach(function() {
@ -30,7 +35,9 @@ describe('<OutlinePane />', function() {
}) })
after(function() { after(function() {
delete global.localStorage Object.defineProperty(global, 'localStorage', {
value: originalLocalStorage
})
}) })
it('renders expanded outline', function() { it('renders expanded outline', function() {

21
services/web/test/frontend/infrastructure/local-storage.test.js
View file

@ -10,22 +10,27 @@ describe('localStorage', function() {
}) })
after(function() { after(function() {
global.localStorage = originalLocalStorage Object.defineProperty(global, 'localStorage', {
value: originalLocalStorage
})
}) })
beforeEach(function() { beforeEach(function() {
global.localStorage = { Object.defineProperty(global, 'localStorage', {
getItem: sinon.stub().returns(null), value: {
setItem: sinon.stub(), getItem: sinon.stub().returns(null),
clear: sinon.stub(), setItem: sinon.stub(),
removeItem: sinon.stub() clear: sinon.stub(),
} removeItem: sinon.stub()
}
})
global.console.error = sinon.stub() global.console.error = sinon.stub()
}) })
afterEach(function() { afterEach(function() {
global.console.error.reset() global.console.error.reset()
delete global.localStorage Object.defineProperty(global, 'localStorage', { value: undefined })
}) })
it('getItem', function() { it('getItem', function() {